[ACS][Common] OPS - Dual Persona #46383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
AikoBB
changed the base branch from
main
to
feature/communication/entra-identity
…ceProvider.FromFile/Directory to take a Uri over string (Azure#46446) * Initial commit * Export API
…re#46447) * Update Nginx changelog to support API version 2024-06-01-preview * Refactor
The focus of these changes is to prepare the Service Bus package for the October 2024 release.
Fix missing HybridSearch in copy SearchOptions
AikoBB
requested review from
allchiang-msft,
mikehang-msft,
gfeitosa-msft,
phermanov-msft,
ilyapaliakou-msft,
besh2014,
danielav7,
miguhern,
LuChen-Microsoft,
minwoolee-msft,
mengaims,
kinelski,
joseharriaga,
dipidoo,
longli0,
ShaoAnLin,
lulululululu,
leareai,
Han-msft,
quentinRobinson,
bidisha-c,
jorgerangel-msft,
trangevi,
dargilco,
jhakulin,
glharper,
a team and
ronniegeraghty
as code owners
AikoBB
merged commit 0f03b6a
into
Azure:feature/communication/entra-identity
381 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces changes to the ACS Common SDK, providing functionality to exchange Entra User tokens for ACS tokens. The key updates include:
CommunicationTokenCredential: Extended with a new constructor that accepts -EntraCommunicationTokenCredentialOptions.EntraTokenCredential: Implementation where the actual token exchange is handled.These changes enhance the SDK by enabling seamless integration of Entra User with Azure Communication Services.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.