Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage][DataMovement] Record some tests that could not be previously recorded #46716

Merged
merged 4 commits into from
Oct 18, 2024
Merged

[Storage][DataMovement] Record some tests that could not be previously recorded #46716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4a6564
Record some tests
jalauzon-msft Oct 18, 2024
221167c
Mark expected failure tests as LiveOnly again for now
jalauzon-msft Oct 18, 2024
bea51c0
Revert nunit
jalauzon-msft Oct 18, 2024
0284b37
Revert nunit again
jalauzon-msft Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/storage/Azure.Storage.DataMovement.Blobs/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "net",
"TagPrefix": "net/storage/Azure.Storage.DataMovement.Blobs",
"Tag": "net/storage/Azure.Storage.DataMovement.Blobs_e796f456ff"
"Tag": "net/storage/Azure.Storage.DataMovement.Blobs_c66f15b319"
}
13 changes: 2 additions & 11 deletions sdk/storage/Azure.Storage.DataMovement.Blobs/tests/ProgressHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,12 @@
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using Azure.Core.TestFramework;
using Azure.Storage.Blobs.Tests;
using Azure.Storage.DataMovement.Blobs.Tests;
using Azure.Storage.DataMovement.Tests;
using BaseBlobs::Azure.Storage.Blobs;
using BaseBlobs::Azure.Storage.Blobs.Models;
using DMBlobs::Azure.Storage.DataMovement.Blobs;
using NUnit.Framework;

namespace Azure.Storage.DataMovement.Tests
namespace Azure.Storage.DataMovement.Blobs.Tests
{
public class ProgressHandlerTests : DataMovementBlobTestBase
{
Expand Down Expand Up @@ -144,7 +141,6 @@ private async Task TransferAndAssertProgress(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task ProgressHandler_DownloadDirectory()
{
// Arrange
Expand All @@ -167,7 +163,6 @@ await TransferAndAssertProgress(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task ProgressHandler_DirectoryUpload()
{
// Arrange
Expand All @@ -190,7 +185,6 @@ await TransferAndAssertProgress(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task ProgressHandler_Copy()
{
// Arrange
Expand All @@ -214,7 +208,6 @@ await TransferAndAssertProgress(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
[TestCase(StorageResourceCreationPreference.SkipIfExists)]
[TestCase(StorageResourceCreationPreference.FailIfExists)]
public async Task ProgressHandler_Conflict(StorageResourceCreationPreference createMode)
Expand Down Expand Up @@ -246,7 +239,6 @@ await TransferAndAssertProgress(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
[TestCase(TransferDirection.Upload)]
[TestCase(TransferDirection.Download)]
[TestCase(TransferDirection.Copy)]
Expand Down Expand Up @@ -308,7 +300,6 @@ await TransferAndAssertProgress(

[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/35558")]
[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
[TestCase(0)]
[TestCase(150)]
public async Task ProgressHandler_PauseResume(int delayInMs)
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/Azure.Storage.DataMovement.Files.Shares/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "net",
"TagPrefix": "net/storage/Azure.Storage.DataMovement.Files.Shares",
"Tag": "net/storage/Azure.Storage.DataMovement.Files.Shares_4eaa88bc73"
"Tag": "net/storage/Azure.Storage.DataMovement.Files.Shares_44f04e1278"
}
20 changes: 3 additions & 17 deletions sdk/storage/Azure.Storage.DataMovement/tests/Shared/StartTransferDirectoryCopyTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
using System.Threading.Tasks;
using Azure.Core;
using Azure.Core.TestFramework;
using Azure.Storage.Common;
using Azure.Storage.Test.Shared;
using NUnit.Framework;

Expand Down Expand Up @@ -276,7 +275,6 @@ await VerifyResultsAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
[TestCase(0, 10)]
[TestCase(DataMovementTestConstants.KB / 2, 10)]
[TestCase(DataMovementTestConstants.KB, 10)]
Expand Down Expand Up @@ -357,7 +355,6 @@ await CopyDirectoryAndVerifyAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task DirectoryToDirectory_EmptyFolder()
{
// Arrange
Expand Down Expand Up @@ -398,7 +395,6 @@ await TestTransferWithTimeout.WaitForCompletionAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task DirectoryToDirectory_SingleFile()
{
// Arrange
Expand All @@ -423,7 +419,6 @@ await CopyDirectoryAndVerifyAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task DirectoryToDirectory_ManySubDirectories()
{
// Arrange
Expand Down Expand Up @@ -458,7 +453,6 @@ await CopyDirectoryAndVerifyAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
[TestCase(1)]
[TestCase(2)]
[TestCase(3)]
Expand Down Expand Up @@ -493,7 +487,6 @@ await CopyDirectoryAndVerifyAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task DirectoryToDirectory_OverwriteExists()
{
// Arrange
Expand Down Expand Up @@ -543,7 +536,6 @@ await CopyDirectoryAndVerifyAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task DirectoryToDirectory_OverwriteNotExists()
{
// Arrange
Expand Down Expand Up @@ -589,7 +581,6 @@ await CopyDirectoryAndVerifyAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public virtual async Task DirectoryToDirectory_OAuth()
{
// Arrange
Expand Down Expand Up @@ -698,7 +689,6 @@ private async Task<DataTransfer> CreateStartTransfer(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task StartTransfer_AwaitCompletion()
{
// Arrange
Expand Down Expand Up @@ -729,7 +719,7 @@ await TestTransferWithTimeout.WaitForCompletionAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/46717
public async Task StartTransfer_AwaitCompletion_Failed()
{
// Arrange
Expand Down Expand Up @@ -767,7 +757,6 @@ await TestTransferWithTimeout.WaitForCompletionAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task StartTransfer_AwaitCompletion_Skipped()
{
// Arrange
Expand Down Expand Up @@ -805,7 +794,6 @@ await TestTransferWithTimeout.WaitForCompletionAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task StartTransfer_EnsureCompleted()
{
// Arrange
Expand Down Expand Up @@ -837,7 +825,7 @@ public async Task StartTransfer_EnsureCompleted()
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/46717
public async Task StartTransfer_EnsureCompleted_Failed()
{
// Arrange
Expand Down Expand Up @@ -875,7 +863,6 @@ public async Task StartTransfer_EnsureCompleted_Failed()
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task StartTransfer_EnsureCompleted_Skipped()
{
// Arrange
Expand Down Expand Up @@ -913,7 +900,7 @@ public async Task StartTransfer_EnsureCompleted_Skipped()
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/46717
public async Task StartTransfer_EnsureCompleted_Failed_SmallChunks()
{
// Arrange
Expand Down Expand Up @@ -1025,7 +1012,6 @@ await VerifyResultsAsync(
[TestCase((int) TransferPropertiesTestType.Preserve)]
[TestCase((int) TransferPropertiesTestType.NoPreserve)]
[TestCase((int) TransferPropertiesTestType.NewProperties)]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task CopyRemoteObjects_VerifyProperties(int propertiesType)
{
// Arrange
Expand Down
17 changes: 3 additions & 14 deletions ...storage/Azure.Storage.DataMovement/tests/Shared/StartTransferDirectoryDownloadTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ private async Task DownloadDirectoryAndVerifyAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
[TestCase(0, 10)]
[TestCase(100, 10)]
[TestCase(Constants.KB, 10)]
Expand Down Expand Up @@ -228,7 +227,6 @@ await DownloadDirectoryAndVerifyAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task DownloadDirectoryAsync_Empty()
{
// Arrange
Expand Down Expand Up @@ -266,7 +264,6 @@ await TestTransferWithTimeout.WaitForCompletionAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task DownloadDirectoryAsync_SingleFile()
{
// Arrange
Expand All @@ -280,7 +277,6 @@ await DownloadDirectoryAndVerifyAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task DownloadDirectoryAsync_ManySubDirectories()
{
// Arrange
Expand All @@ -304,7 +300,6 @@ await DownloadDirectoryAndVerifyAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
[TestCase(1)]
[TestCase(2)]
[TestCase(3)]
Expand Down Expand Up @@ -332,7 +327,6 @@ await DownloadDirectoryAndVerifyAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task DownloadDirectoryAsync_SmallChunks_ManyFiles()
{
// Arrange
Expand Down Expand Up @@ -379,7 +373,6 @@ await DownloadDirectoryAndVerifyAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task DownloadDirectoryAsync_Root()
{
// Arrange
Expand Down Expand Up @@ -450,7 +443,6 @@ private async Task<DataTransfer> CreateStartTransfer(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task StartTransfer_AwaitCompletion()
{
// Arrange
Expand Down Expand Up @@ -483,7 +475,7 @@ await TestTransferWithTimeout.WaitForCompletionAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/46717
public async Task StartTransfer_AwaitCompletion_Failed()
{
// Arrange
Expand Down Expand Up @@ -525,7 +517,6 @@ await TestTransferWithTimeout.WaitForCompletionAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task StartTransfer_AwaitCompletion_Skipped()
{
// Arrange
Expand Down Expand Up @@ -567,7 +558,6 @@ await TestTransferWithTimeout.WaitForCompletionAsync(
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task StartTransfer_EnsureCompleted()
{
// Arrange
Expand Down Expand Up @@ -601,7 +591,7 @@ public async Task StartTransfer_EnsureCompleted()
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/46717
public async Task StartTransfer_EnsureCompleted_Failed()
{
// Arrange
Expand Down Expand Up @@ -643,7 +633,6 @@ public async Task StartTransfer_EnsureCompleted_Failed()
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
public async Task StartTransfer_EnsureCompleted_Skipped()
{
// Arrange
Expand Down Expand Up @@ -685,7 +674,7 @@ public async Task StartTransfer_EnsureCompleted_Skipped()
}

[Test]
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/33082
[LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/46717
public async Task StartTransfer_EnsureCompleted_Failed_SmallChunks()
{
// Arrange
Expand Down