Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync eng/common directory with azure-sdk-tools for PR 9216 #46739

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Sync eng/common directory with azure-sdk-tools for PR 9216 #46739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/common/TestResources/deploy-test-resources.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ parameters:
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources)
ServiceConnection: not-specified
ResourceType: test
UseFederatedAuth: false
UseFederatedAuth: true
PersistOidcToken: false

# SubscriptionConfiguration will be splatted into the parameters of the test
Expand Down
2 changes: 1 addition & 1 deletion eng/common/TestResources/remove-test-resources.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ parameters:
ServiceConnection: not-specified
ResourceType: test
EnvVars: {}
UseFederatedAuth: false
UseFederatedAuth: true

# SubscriptionConfiguration will be splat into the parameters of the test
# resources script. It should be JSON in the form:
Expand Down
12 changes: 0 additions & 12 deletions eng/common/TestResources/sub-config/AzureChinaMsft.json
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions eng/common/TestResources/sub-config/AzurePreviewMsft.json
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions eng/common/TestResources/sub-config/AzurePublicMsft.json
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions eng/common/TestResources/sub-config/AzureUsGovMsft.json
View file
Open in desktop

This file was deleted.

10 changes: 2 additions & 8 deletions eng/common/pipelines/templates/jobs/perf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,7 @@ jobs:
ServiceDirectory: ${{ parameters.ServiceDirectory }}
Location: westus
ResourceType: perf
ServiceConnection: azure-sdk-tests
SubscriptionConfigurationFilePaths:
- eng/common/TestResources/sub-config/AzurePublicMsft.json
UseFederatedAuth: true
ServiceConnection: azure-sdk-tests-public

- script: >-
dotnet run -- run
Expand Down Expand Up @@ -183,7 +180,4 @@ jobs:
parameters:
ServiceDirectory: ${{ parameters.ServiceDirectory }}
ResourceType: perf
ServiceConnection: azure-sdk-tests
SubscriptionConfigurationFilePaths:
- eng/common/TestResources/sub-config/AzurePublicMsft.json
UseFederatedAuth: true
ServiceConnection: azure-sdk-tests-public