Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playwrighttesting): await upload buffer method #47056

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix(playwrighttesting): await upload buffer method #47056

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2a564a
fix(playwrighttesting): await upload buffer method
Nov 11, 2024
4ac702e
chore(): move to upload buffer sync
Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ting/Azure.Developer.MicrosoftPlaywrightTesting.TestLogger/src/Processor/TestProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,9 @@ public void TestRunCompleteHandler(object? sender, TestRunCompleteEventArgs e)
// Upload rawResult to blob storage using sasUri
var rawTestResultJson = JsonSerializer.Serialize(rawResult);
var filePath = $"{testResult.TestExecutionId}/rawTestResult.json";
_blobService.UploadBufferAsync(sasUri!.Uri!, rawTestResultJson, filePath);
#pragma warning disable AZC0102 // Do not use GetAwaiter().GetResult().
_blobService.UploadBufferAsync(sasUri!.Uri!, rawTestResultJson, filePath).GetAwaiter().GetResult();
Sid200026 marked this conversation as resolved.
Show resolved Hide resolved
#pragma warning restore AZC0102 // Do not use GetAwaiter().GetResult().
}
else
{
Expand Down