Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DnsZonePartner Parameter to MI Creation #4801

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

ziwa-msft
Copy link
Contributor

@ziwa-msft ziwa-msft commented Sep 27, 2018

Adding DNS Zone Parameter to Managed Instance Creation workflow. This change introduces new properties DnsZone, DnsZonePartner and Collation into the managed instance entity.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • [ x] Title of the pull request is clear and informative.
  • [x ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [x ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • [ x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • [ x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • [ x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update Assembly version in the csproj and AssemblyInfo,cs files

@dsgouda
Copy link
Contributor

dsgouda commented Sep 27, 2018

Please update the PR with latest remote changes

@ziwa-msft ziwa-msft force-pushed the dnsZone branch 2 times, most recently from bd7c5f2 to eff1f2c Compare September 27, 2018 22:00
@ziwa-msft ziwa-msft force-pushed the dnsZone branch 2 times, most recently from eff1f2c to faf3fa8 Compare September 27, 2018 22:36
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge once CIs pass

@dsgouda
Copy link
Contributor

dsgouda commented Sep 28, 2018

@ziwa-msft Please link the REST Spec PR

@ziwa-msft
Copy link
Contributor Author

Leave a comment

@ziwa-msft Please link the REST Spec PR

Link to Swagger is: Azure/azure-rest-api-specs#3875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants