[Extensions] Fix ASP.NET Core integration testing #48426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The focus of these changes is to fix an assumption in the logic when creating clients from configuration. Currently, if the configuration section has a non-null value, it is assumed to be a connection string. This is not the case for ASP.NET Core test integration due to a bug in the test host which causes the Value property to return an empty string rather than the null returned by the actual configuration system.
jsquire
added
Client
|
API change check API changes are not detected in this pull request. |
christothes
reviewed
Feb 25, 2025
sdk/extensions/Microsoft.Extensions.Azure/Directory.Build.props
Outdated
Show resolved
Hide resolved
m-redding
approved these changes
Feb 26, 2025
sdk/extensions/Microsoft.Extensions.Azure/tests/Microsoft.Extensions.Azure.Tests.csproj
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to fix an assumption in the logic when creating clients from configuration. Currently, if the configuration section has a non-null value, it is assumed to be a connection string.
This is not the case for ASP.NET Core test integration due to a bug in the test host which causes the Value property to return an empty string rather than the null returned by the actual configuration system.
References and related