Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Support Storage Account failover #4850

Closed
wants to merge 1 commit into from

Conversation

blueww
Copy link
Member

@blueww blueww commented Oct 9, 2018

Description

The feature target to release on 10/15. Since the time limitation, send PR directly to public repo. Please help to review it ASAP.

Swagger PR (in review) : Azure/azure-rest-api-specs#4107

Rest Spec :
Failover: https://microsoft.sharepoint.com/:w:/r/teams/AzureStorage/_layouts/15/Doc.aspx?sourcedoc=%7B77CFF0F4-AFAD-4AC1-B51C-1F17C92E06AF%7D&file=SRP%20Customer-controlled%20failover%20API.docx&action=default&mobileredirect=true
Get Last Sync Time:https://microsoft.sharepoint.com/:w:/r/teams/AzureStorage/_layouts/15/doc2.aspx?sourcedoc=%7bad30891d-7c70-4d4f-9b95-046d40fa900d%7d&action=edit&wdPid=660b6155


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dsgouda
Copy link
Contributor

dsgouda commented Oct 10, 2018

@blueww I see the REST spec PR is waiting on ARM review. The initial PR looks good but I would wait on the spec to be merged before approving

@dsgouda
Copy link
Contributor

dsgouda commented Oct 16, 2018

@blueww could you open a new PR when the spec is ready? I can review it again

@dsgouda dsgouda closed this Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants