Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New SDK for 2018-06-30 changes and other nit fixes ver2 #4971

Merged
merged 7 commits into from
Oct 30, 2018
Merged

New SDK for 2018-06-30 changes and other nit fixes ver2 #4971

merged 7 commits into from
Oct 30, 2018

Conversation

D1v38om83r
Copy link
Contributor

@D1v38om83r D1v38om83r commented Oct 30, 2018 •
edited
Loading

Description

  1. Python2Packages for azure automation. Added new API specs, re-recorded tests for Automation scenarios. Added a new test for Python2Package scenarios.
    API PR: Created specs for python 2 packages azure-rest-api-specs#3713

  2. Dynamic Group support change
    API PR : Swagger change for Update configuration dynamic group azure-rest-api-specs#4165

  3. Pre- post support change
    API PR : Swagger change for pre and post script azure-rest-api-specs#4298

Following on from #4916

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@D1v38om83r
Copy link
Contributor Author

@dsgouda
Continuation of PR #4971
These are the changes that we recovered from a saved branch.

They have all the changes minus the ones that you committed in the course of the last PR.

@D1v38om83r D1v38om83r mentioned this pull request Oct 30, 2018
Closed
9 tasks
dsgouda
dsgouda suggested changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just needs a couple of quick fixes

src/SDKs/Automation/Management.Automation/Properties/AssemblyInfo.cs Outdated
@@ -8,7 +8,7 @@
[assembly: AssemblyDescription("Provides Microsoft Azure Automation management operations including the ability to create, update and delete runbooks and schedules.")]

[assembly: AssemblyVersion("3.0.1.0")]
[assembly: AssemblyFileVersion("3.3.0.0")]
[assembly: AssemblyFileVersion("3.8.0-preview")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this to 3.8.0.0 (-preview is not allowed in file versioning)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/SDKs/Automation/Management.Automation/Microsoft.Azure.Management.Automation.csproj
@@ -6,7 +6,7 @@
<PropertyGroup>
<PackageId>Microsoft.Azure.Management.Automation</PackageId>
<Description>Provides Microsoft Azure Automation management operations including the ability to create, update and delete runbooks and schedules.</Description>
<Version>3.4.0-preview</Version>
<Version>3.8.0-preview</Version>
<!-- Remove the Preview description in PackageReleaseNotes once the preview is removed.-->
<AssemblyTitle>Microsoft Azure Automation Management Library</AssemblyTitle>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing PackageReleaseNotes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added package release notes.

@D1v38om83r
Copy link
Contributor Author

@dsgouda
src\SDKs_metadata\automation_resource-manager.txt was changed as a part of SDK generation tool. Is it a relevant change?

@dsgouda
Copy link
Contributor

dsgouda commented Oct 30, 2018

Yes this is expected

dsgouda
dsgouda approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 7d1c598 into Azure:psSdkJson6 Oct 30, 2018
@dsgouda
Copy link
Contributor

dsgouda commented Oct 30, 2018

@D1v38om83r appreciate your patience.

ahamad-MS pushed a commit to ahamad-MS/azure-sdk-for-net that referenced this pull request Oct 31, 2018
@D1v38om83r
New SDK for 2018-06-30 changes and other nit fixes ver2 (Azure#4971)
17c9bcb 
* Generated SDK using generate.ps1

* Added changes to RP.Props

* Added SDK for Automation.Python2Packages and re-recorded tests

* Reduced poll interval for modules and python2packages for faster playback

* new test python2 packages, DynamicGroup and Prepost

* Changed version for assembyinfo and csproj files

* Addressed PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@D1v38om83r @dsgouda @jemex