Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automation] SavedSearch Dynamic group Sdk change and other nit fixes #5187

Closed
wants to merge 1 commit into from
Closed

[Automation] SavedSearch Dynamic group Sdk change and other nit fixes #5187

wants to merge 1 commit into from

Conversation

jemex
Copy link
Contributor

@jemex jemex commented Jan 29, 2019

Description
Dynamic Group support change
API PR: Azure/azure-rest-api-specs#4964

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • [x ] Title of the pull request is clear and informative.
  • [ x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [x ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • [x ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • [x ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get latest source from master and target against master branch.
Also go through the documentation and use the generate.ps1 to generate your SDK.
The generated SDK is lacking metadata that is important, follow step 7 from below documentation
https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#sdk-directory-structure-and-sdk-generation

@shahabhijeet
Copy link
Member

This PR cannot be accepted as is, take the appropriate action as described above and open a new PR.
Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants