Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Automation] SavedSearch Dynamic group Sdk change and other nit fixes #5194

Merged
merged 5 commits into from
Feb 6, 2019
Merged

[Automation] SavedSearch Dynamic group Sdk change and other nit fixes #5194

merged 5 commits into from
Feb 6, 2019

Conversation

jemex
Copy link
Contributor

@jemex jemex commented Jan 31, 2019 •
edited
Loading

Description

Dynamic Group support change
API PR: Azure/azure-rest-api-specs#4964

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • [x ] Title of the pull request is clear and informative.
  • [x ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [x ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • [ x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • [x ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dsgouda
Copy link
Contributor

dsgouda commented Feb 1, 2019

Please linlk the rest spec PR here
Was this code generated using generate.ps1 script? Please regenerate it with the script and commit all changes generated.

@jemex
Copy link
Contributor Author

jemex commented Feb 1, 2019

@dsgouda , the Spec PR link is added. also add it here
Azure/azure-rest-api-specs#4964

Yes, I used the generate.ps1 script to generate the sdk. all the changes are included in this PR

dsgouda
dsgouda suggested changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generating with generate.ps1 should generate changes to .txt and SdkInfo_*.cs file, please commit these changes

@jemex
Copy link
Contributor Author

jemex commented Feb 5, 2019

Hi @dsgouda,
I added all the changes that was generated. SdkInfo_*.cs has not changed, so it didn't show up here.

dsgouda
dsgouda suggested changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the AssemblyVersion to 3.8.1-preview (in csproj) and AssemblyInfo.cs files, also update the PackageReleaseNotes too

dsgouda
dsgouda approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge when CIs pass

@dsgouda dsgouda merged commit bed26d8 into Azure:master Feb 6, 2019
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@jemex @mentat9
[Automation] SavedSearch Dynamic group Sdk change and other nit fixes (…
61b352e 
…Azure#5194)

* SDK change for saved search dynamic group

* Adding all the generated files

* bumping the version up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jemex @dsgouda @shahabhijeet