Fix plugin #53612
Merged
Fix plugin #53612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
AI Model Inference
AI Projects
Client
JoshLove-msft
commented
Oct 31, 2025
sdk/ai/Azure.AI.Projects/src/Custom/AIProjectConnectionsOperations.cs
Outdated
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
sdk/ai/Azure.AI.Projects/src/Custom/AIProjectConnectionsOperations.cs
Outdated
Show resolved
Hide resolved
sdk/ai/Azure.AI.Projects/src/Custom/AIProjectConnectionsOperations.cs
Outdated
Show resolved
Hide resolved
sdk/ai/Azure.AI.Projects/src/Custom/Connections/AIProjectConnectionsOperations.cs
Outdated
Show resolved
Hide resolved
JoshLove-msft
force-pushed
the
fix-plugin
branch
from
f1ad355 to
c37a2f3
Compare
JoshLove-msft
requested review from
ArcturusZhang,
benbp,
christothes,
hallipr,
jsquire,
live1206 and
weshaggard
as code owners
jorgerangel-msft
approved these changes
Nov 3, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR extends the SpecialHeadersVisitor to support optionally adding back the x-ms-client-request-id header in generated request methods, enabling the Client Plugin to include this header when needed.
- Modified
SpecialHeadersVisitorto accept a boolean parameter controlling whether to includex-ms-client-request-idin requests - Added build targets for the Client Plugin to both
service.projandCodeGeneration.targets - Updated the Client Plugin to use the new
SpecialHeadersVisitorparameter
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/service.proj | Added BuildPlugin target and updated GenerateCode to depend on it; cleaned up whitespace |
| eng/packages/plugins/client/Client.Plugin/src/ClientPlugin.cs | Updated SpecialHeadersVisitor instantiation to include x-ms-client-request-id in requests |
| eng/packages/plugins/client/Client.Plugin/src/Client.Plugin.csproj | Refactored property name from VisitorsSharedSource to AzureGeneratorSource and simplified LinkBase paths |
| eng/packages/plugins/client/Client.Plugin/ci.yml | Added trigger path for http-client-csharp to trigger CI when generator changes |
| eng/packages/http-client-csharp/generator/Azure.Generator/test/Visitors/SpecialHeadersVisitorTests.cs | Expanded test coverage to verify both modes of header inclusion and refactored to test multiple operations |
| eng/packages/http-client-csharp/generator/Azure.Generator/test/TestHelpers/MockHelpers.cs | Added visitors parameter to allow injecting custom visitors during testing |
| eng/packages/http-client-csharp/generator/Azure.Generator/src/Visitors/SpecialHeadersVisitor.cs | Refactored to support optional inclusion of x-ms-client-request-id header via constructor parameter and split logic into two methods |
| eng/CodeGeneration.targets | Added BuildPlugin target with skip condition and updated GenerateCode to depend on it |
eng/packages/http-client-csharp/generator/Azure.Generator/src/Visitors/SpecialHeadersVisitor.cs
Show resolved
Hide resolved
|
/check-enforcer evaluate |
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.