Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse AddPolicy parameters #7654

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Reverse AddPolicy parameters #7654

merged 1 commit into from
Sep 17, 2019

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented Sep 17, 2019

Fixes: #7652

Breaking change

Before

options.AddPolicy(HttpPipelinePosition.PerCall, new AddHeaderPolicy());

After:

options.AddPolicy(new AddHeaderPolicy(), HttpPipelinePosition.PerCall);

tg-msft
tg-msft approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@tg-msft tg-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be simpler to just have AddPerCallPolicy(p) and AddPerRetryPolicy(p) methods?

@pakrym
Copy link
Contributor Author

pakrym commented Sep 17, 2019

@tg-msft as far as I remember they were removed by @KrzysztofCwalina request.

@pakrym pakrym merged commit ef4f5d5 into Azure:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tg-msft tg-msft tg-msft approved these changes

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@amnguye amnguye Awaiting requested review from amnguye

@annelo-msft annelo-msft Awaiting requested review from annelo-msft

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft

Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reverse parameter order of AddPolicy methods
2 participants
@pakrym @tg-msft