[Data Factory][Bug fix before SDK publishing] Add new sub resource wrapper with name property #7874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexGhiondea
reviewed
Oct 2, 2019
| @@ -80,7 +80,7 @@ public CreateDataFlowDebugSessionRequest(string computeType = default(string), i | |||
| /// debug session. | |||
| /// </summary> | |||
| [JsonProperty(PropertyName = "integrationRuntime")] | |||
| public IntegrationRuntimeResource IntegrationRuntime { get; set; } | |||
| public IntegrationRuntimeDebugResource IntegrationRuntime { get; set; } | |||
There was a problem hiding this comment.
I assume this breaking change is intentional and covered by the version bump to 4.2.0?
There was a problem hiding this comment.
@AlexGhiondea This API hasn't been released yet, we are releasing it now.
markcowl
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swagger PR: Azure/azure-rest-api-specs#7366
Note: We haven't published 4.2.0 version for our SDK nuget yet, the plan is to merge this PR first and then generate the new SDK thus I reverted the 4.2.1 in code and merge all change diffs into 4.2.0