This repository has been archived by the owner on May 5, 2023. It is now read-only.
Azure Pipeline for KeyVault #4226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Creating a variable "path" overwrites the PATH env var which breaks the world
mikeharder
requested review from
sergey-shandar,
a user,
salameer and
kpajdzik
|
Can one of the admins verify this patch? |
mikeharder
commented
Nov 30, 2018
| @@ -139,6 +139,7 @@ | |||
| "json-stable-stringify": "^1.0.1", | |||
| "minami": "devigned/minami#master", | |||
| "mocha": "^5.2.0", | |||
| "mocha-junit-reporter": "^1.18.0", | |||
There was a problem hiding this comment.
Required for pipeline to publish test results
mikeharder
commented
Nov 30, 2018
| @@ -168,6 +169,7 @@ | |||
| "ci": "node scripts/unit.js testlist.txt", | |||
| "runtime-install": "node scripts/runtime-install.js", | |||
| "coverage": "node scripts/unit-coverage.js testlistarm.txt testlist.txt", | |||
| "debug": "node --inspect scripts/unit-arm.js testlistarm.txt" | |||
| "debug": "node --inspect scripts/unit-arm.js testlistarm.txt", | |||
| "mocha": "mocha" | |||
There was a problem hiding this comment.
I added this script so the pipeline can call "npm run mocha" with options to run a subset of tests.
kpajdzik
reviewed
Nov 30, 2018
kpajdzik
approved these changes
Nov 30, 2018
ghost
approved these changes
Nov 30, 2018
sergey-shandar
approved these changes
Nov 30, 2018
AutorestCI
added a commit
that referenced
this pull request
Dec 5, 2018
…o be more consistent (#4371) * Regenerate azure-arm-resource and bump the SwaggerToSDK generator version * Rename dataLake.Store to datalake.Store * Fix datalake.Store file references * Fix datalake.Store casing in a few more test files * Fix tests and allow for case-insensitive property name lookup in deserialization * Bump required version of ms-rest * Update Changelog.md * Fix tests and allow for case-insensitive property name lookup in deserialization * Bump required version of ms-rest * Update package.json * Revert test changes * Fix bad revert * Add unit tests for getPropertyValue() * Update dependencies and version of azure-cognitiveservices-vision * Run npm install after changes * Remove test script from azure-cognitiveservices-vision * Generated from 72a407cfc5a6c42c060e6dbce2c9ab041486fa55 (#4201) address farhan comment * Update azure-arm-network to 11.0.0 * Generate azure-arm-kusto * Add README.md back * Delete networkManagement2/lib folder * Regenerate azure-arm-network * Update azure-arm-network to 11.0.1 * Regenerate azure-cognitiveservices-luis-runtime * Update azure-cognitiveservices-luis-runtime to 1.1.1 * Azure Pipeline for KeyVault (#4226) * Remove component governance (#4236) * Add status badge for client libraries (#4235) - Remove NPM status badge, since the azure "rollup" package is no longer being shipped * Parameterize source and test paths in pipeline (#4237) * Regenerate azure-arm-machinelearning and update package.json file * Generate azure-arm-sqlvirtualmachine * Fix README.md issues in LUIS runtime * Regenerate azure-cognitiveservices-luis-authoring * Update azure-cognitiveservices-luis-authoring to 2.0.0 * Update generator version to use * Regenerate azure-arm-containerregistry * Update azure-arm-containerregistry to 4.3.0 * Generate azure-cognitiveservices-qnamaker * Regenerate azure-arm-logic * Update azure-arm-logic to 4.2.0 * Generated from 10e5ed698dece8c082c064680537ebae7f3a14b7 updating file due to not desired automatic formatting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipeline: https://dev.azure.com/azure-sdk/playground/_build?definitionId=31&_a=summary