This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Drops mcrypt #991
Merged
Drops mcrypt #991
+90
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
captn3m0
force-pushed
the
no-more-mcrypt
branch
from
f34e003 to
58aa57c
Compare
- This implementation is same as https://github.com/paragonie/random_compat/blob/master/lib/random_int.php - Fixes Azure#918
captn3m0
force-pushed
the
no-more-mcrypt
branch
from
58aa57c to
1c01782
Compare
|
Can this be reviewed please? Tests are passing. |
sergey-shandar
approved these changes
Dec 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
random_intpolyfill (I'm running 7.2 and the upgrade is painful till phpdocumentor has a compatible release, so I didn't use the package instead) - Can take this up if really necessary.mcrypt_encryptchanges are not tested as thoroughly as I'd like (help is appreciated)