Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access ShareClient using ClientSecretCredential #11492

Closed
TadasBaltrusaitis opened this issue May 18, 2020 · 3 comments
Closed

Access ShareClient using ClientSecretCredential #11492

TadasBaltrusaitis opened this issue May 18, 2020 · 3 comments
Assignees
@xiafu-msft @tasherif-msft
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)
Milestone
Backlog

Comments

@TadasBaltrusaitis
Copy link

Currently it is possible to access azure.storage.blob.ContainerClient using azure.identity.ClientSecretCredential. However, unless I am missing something, to access azure.storage.fileshare.ShareClient we need to provide an SAS token or an account key (which might be difficult to acquire).

It would be great if we could pass the same credentials that we use to access ContainerClient to access the ShareClient (it would also increase the consistency between the interfaces).
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 18, 2020
@lmazuel lmazuel added Client This issue points to a problem in the data-plane of the library. Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files) labels May 18, 2020
@ghost
Copy link

ghost commented May 18, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.

@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 18, 2020
@xiafu-msft xiafu-msft added the feature-request This issue requires a new behavior in the product in order be resolved. label May 18, 2020
@xiafu-msft
Copy link
Contributor

Hi @TadasBaltrusaitis

Thanks for reaching out. We will have a discussion with service side and see if they have plan to add AAD auth support!

@lmazuel lmazuel removed the question The issue doesn't require a change to the product in order to be resolved. Most issues start as that label May 26, 2020
@lmazuel lmazuel added this to the Backlog milestone May 26, 2020
@tasherif-msft tasherif-msft self-assigned this Oct 7, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Nov 11, 2020
@paulgmiller @bcho
@levimm @mainred @norshtein @bowang-666
CodeGen from PR 11588 in Azure/azure-rest-api-specs
7edc4ca 
Dev containerservice microsoft.container service 2020 11 01 (Azure#11588)

* Adds base for updating Microsoft.ContainerService from version stable/2020-09-01 to version 2020-11-01

* Updates readme

* Updates API version in new specs and examples

* add autoupgradeprofile to 2020-11-01 (Azure#11363)

* add autoupgradeprofile

* add autoupgrader profile to mc

* format change

Co-authored-by: Xiahe Liu <Xiahe.Liu@microsoft.com>

* add pod subnet id on agentpool (Azure#11310)

* aks: add pod identity profile spec (Azure#11366)

* add private dns zone property in 2020-11-01 (Azure#11311)

Co-authored-by: Li Ma <lima2@microsoft.com>

* Remove invalid pattern and adjust description (Azure#11312)

* aks: fix pod identity profile field names (Azure#11484)

* aks: add missing `podIdentityProfile.enabled` field

* aks: typo

* add non upgrade channel (Azure#11492)

Co-authored-by: Xiahe Liu <Xiahe.Liu@microsoft.com>

* Make identityProfile mutable (Azure#11458)

* Add KubeletConfig and LinuxOSConfig specs (Azure#11490)

* aks: update readme tag for 1101 (Azure#11472)

* aks: update readme tag

* aks: add `2020-11-01-only`

* resovle merge conlicts to master, adding recent master change to dev branch (Azure#11604)

Co-authored-by: Xiahe Liu <Xiahe.Liu@microsoft.com>

Co-authored-by: Xiahe Liu <Xiahe.Liu@microsoft.com>
Co-authored-by: Paul Miller <pmiller@microsoft.com>
Co-authored-by: hbc <me@hbc.rocks>
Co-authored-by: Super <mali_no2@hotmail.com>
Co-authored-by: Li Ma <lima2@microsoft.com>
Co-authored-by: Qingchuan Hao <haoqingchuan@hotmail.com>
Co-authored-by: Tongyao Si <tosi@microsoft.com>
Co-authored-by: Bo Wang <61758179+bowang-666@users.noreply.github.com>
Co-authored-by: Phoenix He <tih@microsoft.com>
@jalauzon-msft
Copy link
Member

Hi @TadasBaltrusaitis Tadas, I realize you opened this quite some time ago and I apologize it's been so long without an update, but we have been waiting on the service to add support for this. I'm happy to report they are working on adding this support and we should be adding it to an upcoming release of the SDK.

As a housekeeping item, I'm going to close this issue as a duplicate of #13033 as it is asking for the same thing, Files support for AAD auth (as that one has a few more people following it). I will comment an update there and use that one to track the upcoming work for Files OAuth. Thanks.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xiafu-msft xiafu-msft

@tasherif-msft tasherif-msft

Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@lmazuel @TadasBaltrusaitis @xiafu-msft @tasherif-msft @jalauzon-msft