Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Must send back sentinel value when updating a SearchIndexerDataSourceConnection #12109

Closed
heaths opened this issue Jun 18, 2020 · 1 comment
Closed

Must send back sentinel value when updating a SearchIndexerDataSourceConnection #12109

heaths opened this issue Jun 18, 2020 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone
[2020] July

Comments

@heaths
Copy link
Member

heaths commented Jun 18, 2020

Through testing, I found that we cannot send back a null or empty SearchIndexerDataSourceConnection.ConnectingString ("credentials"). Instead, you have to use an undocument sentinel value of "" (include brackets). I opened Azure/azure-rest-api-specs#9877 to make sure this gets documented, but it something we'll need to do for GA to support CreateOrUpdateDataSourceConnection properly.
@heaths heaths added Client This issue points to a problem in the data-plane of the library. Search labels Jun 18, 2020
@heaths heaths added this to the [2020] July milestone Jun 18, 2020
@xiangyan99 xiangyan99 mentioned this issue Jun 19, 2020
Merged
@xiangyan99
Copy link
Member

Fixed in #12129

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jan 11, 2021
CodeGen from PR 12109 in Azure/azure-rest-api-specs
38dce66 
[Hub Generated] Review request for Microsoft.SerialConsole to add version stable/2018-05-01 (Azure#12109)

* add serialPort operations

* linting fixes

* fixing whitespacing for prettier check failure

* fix to example naming
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
[2020] July
Development

No branches or pull requests
2 participants
@heaths @xiangyan99