Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identity - support for client certificates in formats other than PEM #13540

Closed
yichungyu opened this issue Sep 3, 2020 · 3 comments · Fixed by #16384
Closed

Identity - support for client certificates in formats other than PEM #13540

yichungyu opened this issue Sep 3, 2020 · 3 comments · Fixed by #16384
Assignees
@chlowell @schaabs
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
[2021] September

Comments

@yichungyu
Copy link

When users wish to use the Identity SDK for Python in conjunction with Azure Batch, they need to implement extra logic to convert their certificate from .pfx/.cer to .pem. Can we add logic so that the Identity SDK supports other certificate formats innately?

Azure Batch documentation on certificates: https://docs.microsoft.com/en-us/azure/batch/batch-certificates
Suspected code where the current restriction for PEM-only certificates is implemented:

azure-sdk-for-python/sdk/identity/azure-identity/azure/identity/_internal/aadclient_certificate.py

Line 19 in eea845a

class AadClientCertificate(object):

Python SDK reference describing the PEM-only restriction: https://azuresdkdocs.blob.core.windows.net/$web/python/azure-identity/1.4.0/index.html#environment-variables
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Sep 3, 2020
@chlowell chlowell added feature-request This issue requires a new behavior in the product in order be resolved. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Sep 3, 2020
@chlowell chlowell added this to the Backlog milestone Sep 3, 2020
@chlowell chlowell added Azure.Identity Client This issue points to a problem in the data-plane of the library. labels Sep 3, 2020
@chlowell
Copy link
Member

Thanks for opening this issue. I've put it on our backlog until we decide where it could fit into our roadmap. Until then, if you're reading this and this feature is important to you, please +1 the top comment to help us prioritize.

This was referenced Jan 22, 2021
Closed
Merged
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Mar 22, 2021
CodeGen from PR 13540 in Azure/azure-rest-api-specs
37d16a3 
Update readme.python.md(Datadog) (Azure#13540)

* Update readme.python.md

* Update readme.python.md
@lmazuel lmazuel modified the milestones: Backlog, [2021] June May 7, 2021
@lmazuel lmazuel modified the milestones: [2021] June, Backlog, [2021] July Jun 18, 2021
@chlowell chlowell modified the milestones: [2021] July, [2021] August Jul 7, 2021
@DhavalShewale
Copy link

@chlowell By when can we expect support for PKCS12 certs to be available in the azure-identity library

@chlowell
Copy link
Member

chlowell commented Sep 1, 2021

#16384 will be in 1.7.0b4, which we plan to release September 8

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chlowell chlowell

@schaabs schaabs

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Milestone
[2021] September
Development

Successfully merging a pull request may close this issue.

CertificateCredential supports PKCS12 certs chlowell/azure-sdk-for-python
5 participants
@lmazuel @chlowell @schaabs @DhavalShewale @yichungyu