Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServiceBus] AutoLockRenewer being opted in ServiceBusReceiver #14706

Closed
yunhaoling opened this issue Oct 22, 2020 · 1 comment · Fixed by #14600
Closed

[ServiceBus] AutoLockRenewer being opted in ServiceBusReceiver #14706

yunhaoling opened this issue Oct 22, 2020 · 1 comment · Fixed by #14600
Assignees
@KieranBrantnerMagee
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone
[2020] November

Comments

@yunhaoling
Copy link
Contributor

yunhaoling commented Oct 22, 2020 •
edited
Loading

  • design:
    • receiver level config, user needs to pass create the autolockrenewer instance and pass it to the get_receiver
    • public api surface of the auto lock renewer

Azure/azure-sdk#1884 (comment)

While we now have auto lock renewal on the receiver level that will automatically renew the locks on the messages/session associated with the receiver, it is still a feature one needs to opt into. Other languages enable this by default. Python to revisit this offline
We have news from the service team that they will be moving away from the lock renewal being a client responsibility and will be enabling it by default. So, Python will be left with different defaults post this change
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 22, 2020
@yunhaoling yunhaoling added Client This issue points to a problem in the data-plane of the library. Service Bus labels Oct 22, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 22, 2020
@yunhaoling yunhaoling added this to the [2020] November milestone Oct 22, 2020
@yunhaoling yunhaoling changed the title [ServiceBus] AutoLockRenewer [ServiceBus] AutoLockRenewer being opted in ServiceBusReceiver Oct 22, 2020
@yunhaoling yunhaoling added the blocking-release Blocks release label Oct 22, 2020
@KieranBrantnerMagee KieranBrantnerMagee self-assigned this Oct 28, 2020
@yunhaoling
Copy link
Contributor Author

proposal is here: https://gist.github.com/yunhaoling/13a5ebb098e72337271409addbfce856

@KieranBrantnerMagee KieranBrantnerMagee linked a pull request Nov 3, 2020 that will close this issue
[ServiceBus] Adjust AutoLockRenewer to only allow registration of intended types (ReceivedMessage and ServiceBusSession) #14600
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KieranBrantnerMagee KieranBrantnerMagee

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
[2020] November
2 participants
@KieranBrantnerMagee @yunhaoling