[ServiceBus] Adjust AutoLockRenewer to only allow registration of intended types (ReceivedMessage and ServiceBusSession) #14600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ReceivedMessage and ServiceBusSession) with the intent that if it was desired to allow an interfaced based approach it'd be easier to open that up later, and provide guardrails for now.
KieranBrantnerMagee
added
Service Bus
Client
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…r, reverted until that goes in.
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
reviewed
Oct 20, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/_common/auto_lock_renewer.py
Outdated
Show resolved
Hide resolved
yunhaoling
reviewed
Oct 20, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/aio/_async_auto_lock_renewer.py
Outdated
Show resolved
Hide resolved
|
aha, you're thinking ahead me, when I was reading the PR I was wondering why we would have to limit our users' ability to reuse But as you mentioned, we could "re-open" if needed. |
++Great minds think alike. I had the same concern initially, but providing a good interface for someone to implement would be a bit of scope creep/overhead on what is otherwise a rather constrained helper, and we could always go that route with intention and thought if we started with the "more narrow" approach, allowing us greater flexibility in the long run. |
Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>
…ister-fail-fast-invalid-type' of https://github.com/KieranBrantnerMagee/azure-sdk-for-python into kibrantn/servicebus/track2-preview8-auto-lock-renew-register-fail-fast-invalid-type
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…us/track2-preview8-auto-lock-renew-register-fail-fast-invalid-type
…due to semantic conflicts with this branch's existing work)
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
reviewed
Oct 29, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/_common/auto_lock_renewer.py
Outdated
Show resolved
Hide resolved
yunhaoling
reviewed
Oct 29, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/aio/_async_auto_lock_renewer.py
Outdated
Show resolved
Hide resolved
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
reviewed
Nov 3, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/aio/_async_auto_lock_renewer.py
Outdated
Show resolved
Hide resolved
yunhaoling
reviewed
Nov 3, 2020
sdk/servicebus/azure-servicebus/tests/async_tests/test_queues_async.py
Outdated
Show resolved
Hide resolved
yunhaoling
reviewed
Nov 3, 2020
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
approved these changes
Nov 4, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Nov 4, 2020
…into add_invoice_multipage * 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits) add more samples (Azure#15007) Address feedbacks: Rename type, improve readme (Azure#14905) Correct Visual Studio Code default environment name (Azure#14648) [ServiceBus] Adjust AutoLockRenewer to only allow registration of intended types (ReceivedMessage and ServiceBusSession) (Azure#14600) Validate tenant IDs used in URLs (Azure#14955) [ServiceBus] Make sub-client initializers internal (add '_' to from_conn_str for receiver/sender) (Azure#14502) Raise minimum msal version to 1.6.0 (Azure#14992) update monitor to target '*' instead of azure-* (Azure#14985) Split create_basic_client into two methods (Azure#14673) [ServiceBus] receive related methods/constructor raise error if given max_wait_time <= 0 (Azure#14925) String unicode deserial (Azure#14958) Clarified exceptions docs (Azure#14947) search-documents: correct method calls in sample (Azure#14980) Catch exceptions thrown by async download (Azure#14946) Increment package version after release of azure_eventgrid (Azure#14266) [ServiceBus] Add additional stress test coverage to ensure parity with cross-language priorities (Azure#14437) Service Bus Connection String Parser (Azure#14772) Remove AmendCommit parameter (Azure#14965) revert creation takes full object change (Azure#14957) [ServiceBus] Settlement move from Message to Receiver (Azure#14681) ...
iscai-msft
pushed a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Nov 4, 2020
…ended types (ReceivedMessage and ServiceBusSession) (Azure#14600) * Adjust AutoLockRenewer to only allow registration of intended types (ReceivedMessage and ServiceBusSession) with the intent that if it was desired to allow an interfaced based approach it'd be easier to open that up later, and provide guardrails for now. * via_partition_key removal assumed another branch had been merged prior, reverted until that goes in. Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Nov 4, 2020
…into add_invoice_multipage_tests * 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits) add more samples (Azure#15007) Address feedbacks: Rename type, improve readme (Azure#14905) Correct Visual Studio Code default environment name (Azure#14648) [ServiceBus] Adjust AutoLockRenewer to only allow registration of intended types (ReceivedMessage and ServiceBusSession) (Azure#14600) Validate tenant IDs used in URLs (Azure#14955) [ServiceBus] Make sub-client initializers internal (add '_' to from_conn_str for receiver/sender) (Azure#14502) Raise minimum msal version to 1.6.0 (Azure#14992) update monitor to target '*' instead of azure-* (Azure#14985) Split create_basic_client into two methods (Azure#14673) [ServiceBus] receive related methods/constructor raise error if given max_wait_time <= 0 (Azure#14925) String unicode deserial (Azure#14958) Clarified exceptions docs (Azure#14947) search-documents: correct method calls in sample (Azure#14980) Catch exceptions thrown by async download (Azure#14946) Increment package version after release of azure_eventgrid (Azure#14266) [ServiceBus] Add additional stress test coverage to ensure parity with cross-language priorities (Azure#14437) Service Bus Connection String Parser (Azure#14772) Remove AmendCommit parameter (Azure#14965) revert creation takes full object change (Azure#14957) [ServiceBus] Settlement move from Message to Receiver (Azure#14681) ...
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Jun 2, 2021
Cost Management: Add typescript support and add more aggregation functions (Azure#14600) * Add typescript support to Cost Management Signed-off-by: Rob Long <Robert.Long@lv.com> * Extend set of aggregation functions Add Avg, Max and Min to set of available aggregation functions. Signed-off-by: Rob Long <Robert.Long@lv.com>
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Jun 2, 2021
Cost Management: Add typescript support and add more aggregation functions (Azure#14600) * Add typescript support to Cost Management Signed-off-by: Rob Long <Robert.Long@lv.com> * Extend set of aggregation functions Add Avg, Max and Min to set of available aggregation functions. Signed-off-by: Rob Long <Robert.Long@lv.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the intent that if it was desired to allow an interfaced based approach it'd be easier to open that up later, and provide guardrails for now.