[ServiceBus] Settlement move from Message to Receiver #14681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
requested review from
annatisch and
KieranBrantnerMagee
as code owners
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
reviewed
Oct 29, 2020
annatisch
reviewed
Oct 29, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/_common/message.py
Outdated
Show resolved
Hide resolved
annatisch
reviewed
Oct 29, 2020
annatisch
reviewed
Oct 29, 2020
annatisch
reviewed
Oct 29, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_receiver.py
Outdated
Show resolved
Hide resolved
annatisch
reviewed
Oct 29, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_receiver.py
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_receiver.py
Outdated
Show resolved
Hide resolved
KieranBrantnerMagee
approved these changes
Nov 2, 2020
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lmazuel
pushed a commit
that referenced
this pull request
Nov 3, 2020
* code change to move settlement from message to receiver * fix mypy * update code change * more code change * sync test code update * update test code * fix mypy and pylint * fix small issue in exception and live test * fix pylint * update sample code, doc, stress test code * update changelog and migration guide * update changelog * address review comments * eliminate duplication code in settlement
lmazuel
pushed a commit
that referenced
this pull request
Nov 3, 2020
* code change to move settlement from message to receiver * fix mypy * update code change * more code change * sync test code update * update test code * fix mypy and pylint * fix small issue in exception and live test * fix pylint * update sample code, doc, stress test code * update changelog and migration guide * update changelog * address review comments * eliminate duplication code in settlement
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Nov 4, 2020
…into add_invoice_multipage * 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits) add more samples (Azure#15007) Address feedbacks: Rename type, improve readme (Azure#14905) Correct Visual Studio Code default environment name (Azure#14648) [ServiceBus] Adjust AutoLockRenewer to only allow registration of intended types (ReceivedMessage and ServiceBusSession) (Azure#14600) Validate tenant IDs used in URLs (Azure#14955) [ServiceBus] Make sub-client initializers internal (add '_' to from_conn_str for receiver/sender) (Azure#14502) Raise minimum msal version to 1.6.0 (Azure#14992) update monitor to target '*' instead of azure-* (Azure#14985) Split create_basic_client into two methods (Azure#14673) [ServiceBus] receive related methods/constructor raise error if given max_wait_time <= 0 (Azure#14925) String unicode deserial (Azure#14958) Clarified exceptions docs (Azure#14947) search-documents: correct method calls in sample (Azure#14980) Catch exceptions thrown by async download (Azure#14946) Increment package version after release of azure_eventgrid (Azure#14266) [ServiceBus] Add additional stress test coverage to ensure parity with cross-language priorities (Azure#14437) Service Bus Connection String Parser (Azure#14772) Remove AmendCommit parameter (Azure#14965) revert creation takes full object change (Azure#14957) [ServiceBus] Settlement move from Message to Receiver (Azure#14681) ...
iscai-msft
pushed a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Nov 4, 2020
* code change to move settlement from message to receiver * fix mypy * update code change * more code change * sync test code update * update test code * fix mypy and pylint * fix small issue in exception and live test * fix pylint * update sample code, doc, stress test code * update changelog and migration guide * update changelog * address review comments * eliminate duplication code in settlement
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Nov 4, 2020
…into add_invoice_multipage_tests * 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits) add more samples (Azure#15007) Address feedbacks: Rename type, improve readme (Azure#14905) Correct Visual Studio Code default environment name (Azure#14648) [ServiceBus] Adjust AutoLockRenewer to only allow registration of intended types (ReceivedMessage and ServiceBusSession) (Azure#14600) Validate tenant IDs used in URLs (Azure#14955) [ServiceBus] Make sub-client initializers internal (add '_' to from_conn_str for receiver/sender) (Azure#14502) Raise minimum msal version to 1.6.0 (Azure#14992) update monitor to target '*' instead of azure-* (Azure#14985) Split create_basic_client into two methods (Azure#14673) [ServiceBus] receive related methods/constructor raise error if given max_wait_time <= 0 (Azure#14925) String unicode deserial (Azure#14958) Clarified exceptions docs (Azure#14947) search-documents: correct method calls in sample (Azure#14980) Catch exceptions thrown by async download (Azure#14946) Increment package version after release of azure_eventgrid (Azure#14266) [ServiceBus] Add additional stress test coverage to ensure parity with cross-language priorities (Azure#14437) Service Bus Connection String Parser (Azure#14772) Remove AmendCommit parameter (Azure#14965) revert creation takes full object change (Azure#14957) [ServiceBus] Settlement move from Message to Receiver (Azure#14681) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing issues:
#14815
#14567
PeekedMessage.ReceivedMessageunder moduleazure.servicebus.aio.ServiceBusMessagetoServiceBusReceiver:ServiceBusReceiver.complete_messageinstead ofServiceBusReceivedMessage.completeto complete a message.ServiceBusReceiver.abandon_messageinstead ofServiceBusReceivedMessage.abandonto abandon a message.ServiceBusReceiver.defer_messageinstead ofServiceBusReceivedMessage.deferto defer a message.ServiceBusReceiver.dead_letter_messageinstead ofServiceBusReceivedMessage.dead_letterto dead letter a message.renew_lockmethod is moved fromServiceBusMessagetoServiceBusReceiver:ServiceBusReceivedMessage.renew_locktoServiceBusReceiver.renew_message_lockAutoLockRenewer.registernow takesServiceBusReceiveras a positional parameter.Note
This PR doesn't include auto_lock_renewer opted into the receiver, it would be a separate PR