Split create_basic_client into two methods

[lmazuel]

Should help with

azure-sdk-for-python/sdk/schemaregistry/azure-schemaregistry/tests/async_tests/test_schema_registry_async.py

Lines 44 to 101 in 83ec2c4

	def create_basic_client(self, client_class, **kwargs):
	# This is the patch for creating client using aio identity
	tenant_id = os.environ.get("AZURE_TENANT_ID", None)
	client_id = os.environ.get("AZURE_CLIENT_ID", None)
	secret = os.environ.get("AZURE_CLIENT_SECRET", None)
	if tenant_id and client_id and secret and self.is_live:
	if _is_autorest_v3(client_class):
	# Create azure-identity class
	from azure.identity.aio import ClientSecretCredential
	credentials = ClientSecretCredential(
	tenant_id=tenant_id,
	client_id=client_id,
	client_secret=secret
	)
	else:
	# Create msrestazure class
	from msrestazure.azure_active_directory import ServicePrincipalCredentials
	credentials = ServicePrincipalCredentials(
	tenant=tenant_id,
	client_id=client_id,
	secret=secret
	)
	else:
	if _is_autorest_v3(client_class):
	credentials = self.AsyncFakeCredential()
	#credentials = self.settings.get_azure_core_credentials()
	else:
	credentials = self.settings.get_credentials()
	# Real client creation
	# FIXME decide what is the final argument for that
	# if self.is_playback():
	# kwargs.setdefault("polling_interval", 0)
	if _is_autorest_v3(client_class):
	kwargs.setdefault("logging_enable", True)
	client = client_class(
	credential=credentials,
	**kwargs
	)
	else:
	client = client_class(
	credentials=credentials,
	**kwargs
	)
	if self.is_playback():
	try:
	client._config.polling_interval = 0 # FIXME in azure-mgmt-core, make this a kwargs
	except AttributeError:
	pass
	if hasattr(client, "config"): # Autorest v2
	if self.is_playback():
	client.config.long_running_operation_timeout = 0
	client.config.enable_http_logger = True
	return client

[yunhaoling]

as now you're approaching the _get_real_credential method for returning real credential, I'm wondering we could do further unification here for this ServicePrincipalCredentials as well.

maybe we could just tweak the _get_real_credential signature a bit, making it

def _get_real_credential(self, is_async=false, crendetial_type=None):
# if crendetial_type is provided, just use the given type
if crendetial_type:
   return crendetial_type(client_id=...)
# otherwise we fall back to some default paths
if is_async:
    from ..

[lmazuel]

@yunhaoling that would have to be a string, since we can't import aio code in 2.7 (right now it works because the aio code is smartly wrapped in the right if).

So I'm not against, but I'm not sure we need in the first place (are we trying to solve an actual problem, or just do something cool for fun? :)) and this string challenge make the API less than ideal.

I'm happy to be pushed back if you strongly believe in it

[yunhaoling]

@lmazuel emmm, I see the reverse, it's because we're in the py2.7 so that we won't be importing and passing aio credential_type into the method -- it's the caller's duty to check which env/is async/etc. and make the right import.
the callee _get_credential simply takes what has been passed.

as you said, it's mostly "something cool for fun" -- the place where I come from is for the long term maintainability/scalability/readability -- that's what a unified approach could potentially provide.

but I might be bikeshedding and overengineering, let's waste no more time on this and get it work in our repo first😊

(btw: I didn't mean to block the PR, I'm good with these changes)

[seankane-msft]

Addresses #13594

[seankane-msft]

/azp run python - tables - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[seankane-msft]

/azp run python - schemaregistry - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[seankane-msft]

/azp run python - tables - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[iscai-msft]

tiniest nit: do we want to log a warning instead of having a comment, more discoverable