revert creation takes full object change #14957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,9 +4,6 @@ | |||
|
|
|||
| **Breaking Changes** | |||
|
|
|||
| - `create_data_feed` now takes as input a `DataFeed` object | |||
| - `create_metric_anomaly_detection_configuration` now takes as input an `AnomalyDetectionConfiguration` object | |||
| - `create_anomaly_detection_configuration` now takes as input an `AnomalyAlertConfiguration` object | |||
| - `create_hook` now takes as input an `EmailHook` or `WebHook` | |||
There was a problem hiding this comment.
Suggested change
| - `create_hook` now takes as input an `EmailHook` or `WebHook` |
There was a problem hiding this comment.
Actually will we make the change to create_hook as well? It used to take the name parameter separate from the object.
There was a problem hiding this comment.
It seems to me the difference is
to take name+hook object -> to hook object only.
I don't think we should revert back to name+object.
| ) | ||
|
|
||
| def _create_data_feed_and_detection_config(self, name): | ||
| data_feed = self._create_data_feed(name) | ||
| detection_config_name = create_random_name(name) | ||
| detection_config_name = self.create_random_name(name) |
kristapratico
approved these changes
Nov 2, 2020
lmazuel
pushed a commit
that referenced
this pull request
Nov 3, 2020
* revert creation takes full object change
lmazuel
pushed a commit
that referenced
this pull request
Nov 3, 2020
* revert creation takes full object change
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Nov 4, 2020
…into add_invoice_multipage * 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits) add more samples (Azure#15007) Address feedbacks: Rename type, improve readme (Azure#14905) Correct Visual Studio Code default environment name (Azure#14648) [ServiceBus] Adjust AutoLockRenewer to only allow registration of intended types (ReceivedMessage and ServiceBusSession) (Azure#14600) Validate tenant IDs used in URLs (Azure#14955) [ServiceBus] Make sub-client initializers internal (add '_' to from_conn_str for receiver/sender) (Azure#14502) Raise minimum msal version to 1.6.0 (Azure#14992) update monitor to target '*' instead of azure-* (Azure#14985) Split create_basic_client into two methods (Azure#14673) [ServiceBus] receive related methods/constructor raise error if given max_wait_time <= 0 (Azure#14925) String unicode deserial (Azure#14958) Clarified exceptions docs (Azure#14947) search-documents: correct method calls in sample (Azure#14980) Catch exceptions thrown by async download (Azure#14946) Increment package version after release of azure_eventgrid (Azure#14266) [ServiceBus] Add additional stress test coverage to ensure parity with cross-language priorities (Azure#14437) Service Bus Connection String Parser (Azure#14772) Remove AmendCommit parameter (Azure#14965) revert creation takes full object change (Azure#14957) [ServiceBus] Settlement move from Message to Receiver (Azure#14681) ...
iscai-msft
pushed a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Nov 4, 2020
* revert creation takes full object change
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Nov 4, 2020
…into add_invoice_multipage_tests * 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits) add more samples (Azure#15007) Address feedbacks: Rename type, improve readme (Azure#14905) Correct Visual Studio Code default environment name (Azure#14648) [ServiceBus] Adjust AutoLockRenewer to only allow registration of intended types (ReceivedMessage and ServiceBusSession) (Azure#14600) Validate tenant IDs used in URLs (Azure#14955) [ServiceBus] Make sub-client initializers internal (add '_' to from_conn_str for receiver/sender) (Azure#14502) Raise minimum msal version to 1.6.0 (Azure#14992) update monitor to target '*' instead of azure-* (Azure#14985) Split create_basic_client into two methods (Azure#14673) [ServiceBus] receive related methods/constructor raise error if given max_wait_time <= 0 (Azure#14925) String unicode deserial (Azure#14958) Clarified exceptions docs (Azure#14947) search-documents: correct method calls in sample (Azure#14980) Catch exceptions thrown by async download (Azure#14946) Increment package version after release of azure_eventgrid (Azure#14266) [ServiceBus] Add additional stress test coverage to ensure parity with cross-language priorities (Azure#14437) Service Bus Connection String Parser (Azure#14772) Remove AmendCommit parameter (Azure#14965) revert creation takes full object change (Azure#14957) [ServiceBus] Settlement move from Message to Receiver (Azure#14681) ...
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Aug 2, 2021
[AKS] Merge dev-containerservice-Microsoft.ContainerService-2021-07-01 to master (Azure#15370) * Adds base for updating Microsoft.ContainerService from version stable/2021-05-01 to version 2021-07-01 * Updates readme * Updates API version in new specs and examples * Modify Swagger to fix the problem of automatically generating ugly names in track 2 (Azure#14758) * update swagger to fix track 2 autogenerated naming issue * fix * update readme for sdk generation * fix lint error * Trigger Build * update readme * Improve AKS Swagger documentation (Azure#14957) * Improve AKS Swagger documentation - This change has already been merged in master for the 2021-05-01 API version. * Fix up custom words * aks: replace CloudError with ManagedClusterPodIdentityProvisioningError for AAD pod identity provisioning spec (Azure#15033) * fix: decouple pod identity provisioning error from cloud error * drop extra external mark * fix linting issue * fix reference * Dev containerservice microsoft.container service 2021 07 01: add SecurityProfile (Azure#15035) * Add SecurityProfile to ManagedClusters * spaces * Space * spaces * json formatting * move from params to defs * :) * just another * now with npm * Descriptions update for AKS July API (Azure#15074) * allow disabling of runcommand (Azure#15092) * allow disabling of runcommand * format error * format with example * change enable to disable * Revert "allow disabling of runcommand (Azure#15092)" (Azure#15147) This reverts commit ec3e241a564d21f5ec914f4aa0b59a96ac7ec0d9. * [AKS] Add NATGatewayProfile to 2021-07-01 API (Azure#15154) * [AKS] Add NATGatewayProfile to 2021-07-01 API * Fix linter errors Co-authored-by: Kaiqi Zhang <kaiqzhan@microsoft.com> * Add scaleDownMode to agent pool properties (Azure#15124) * add scale down mode * address comments * fix markdown link * update proper api version * Resolve python markdown conflict & fix typo (Azure#15402) * resolve python conflict & fix typo * resolve conflict Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com> Co-authored-by: Matthew Christopher <matthchr@microsoft.com> Co-authored-by: hbc <bcxxxxxx@gmail.com> Co-authored-by: Or Parnes <orparnes@gmail.com> Co-authored-by: Haitao Chen <haitch@users.noreply.github.com> Co-authored-by: Kaiqi Zhang <kaiqzhan@microsoft.com> Co-authored-by: Marwan Ahmed <marwanad@microsoft.com> Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com>
msyyc
pushed a commit
that referenced
this pull request
Aug 9, 2021
* CodeGen from PR 15370 in Azure/azure-rest-api-specs [AKS] Merge dev-containerservice-Microsoft.ContainerService-2021-07-01 to master (#15370) * Adds base for updating Microsoft.ContainerService from version stable/2021-05-01 to version 2021-07-01 * Updates readme * Updates API version in new specs and examples * Modify Swagger to fix the problem of automatically generating ugly names in track 2 (#14758) * update swagger to fix track 2 autogenerated naming issue * fix * update readme for sdk generation * fix lint error * Trigger Build * update readme * Improve AKS Swagger documentation (#14957) * Improve AKS Swagger documentation - This change has already been merged in master for the 2021-05-01 API version. * Fix up custom words * aks: replace CloudError with ManagedClusterPodIdentityProvisioningError for AAD pod identity provisioning spec (#15033) * fix: decouple pod identity provisioning error from cloud error * drop extra external mark * fix linting issue * fix reference * Dev containerservice microsoft.container service 2021 07 01: add SecurityProfile (#15035) * Add SecurityProfile to ManagedClusters * spaces * Space * spaces * json formatting * move from params to defs * :) * just another * now with npm * Descriptions update for AKS July API (#15074) * allow disabling of runcommand (#15092) * allow disabling of runcommand * format error * format with example * change enable to disable * Revert "allow disabling of runcommand (#15092)" (#15147) This reverts commit ec3e241a564d21f5ec914f4aa0b59a96ac7ec0d9. * [AKS] Add NATGatewayProfile to 2021-07-01 API (#15154) * [AKS] Add NATGatewayProfile to 2021-07-01 API * Fix linter errors Co-authored-by: Kaiqi Zhang <kaiqzhan@microsoft.com> * Add scaleDownMode to agent pool properties (#15124) * add scale down mode * address comments * fix markdown link * update proper api version * Resolve python markdown conflict & fix typo (#15402) * resolve python conflict & fix typo * resolve conflict Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com> Co-authored-by: Matthew Christopher <matthchr@microsoft.com> Co-authored-by: hbc <bcxxxxxx@gmail.com> Co-authored-by: Or Parnes <orparnes@gmail.com> Co-authored-by: Haitao Chen <haitch@users.noreply.github.com> Co-authored-by: Kaiqi Zhang <kaiqzhan@microsoft.com> Co-authored-by: Marwan Ahmed <marwanad@microsoft.com> Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com> * version,CHANGELOG Co-authored-by: SDKAuto <sdkautomation@microsoft.com> Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com> Co-authored-by: Matthew Christopher <matthchr@microsoft.com> Co-authored-by: hbc <bcxxxxxx@gmail.com> Co-authored-by: Or Parnes <orparnes@gmail.com> Co-authored-by: Haitao Chen <haitch@users.noreply.github.com> Co-authored-by: Kaiqi Zhang <kaiqzhan@microsoft.com> Co-authored-by: Marwan Ahmed <marwanad@microsoft.com> Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.