Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EventHubs] Makes max_size_in_bytes read-only in EventDataBatch #14752

Closed
yunhaoling opened this issue Oct 23, 2020 · 1 comment
Closed

[EventHubs] Makes max_size_in_bytes read-only in EventDataBatch #14752

yunhaoling opened this issue Oct 23, 2020 · 1 comment
Assignees
@yunhaoling
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Event Hubs
Milestone
[2021] March

Comments

@yunhaoling
Copy link
Contributor

make max_size_in_bytes be a property EventDataBatch

#14639

max_size_in_bytes on the batch object should be readonly.
@yunhaoling yunhaoling added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Oct 23, 2020
@yunhaoling yunhaoling added this to the Backlog milestone Oct 23, 2020
@yunhaoling yunhaoling modified the milestones: Backlog, [2021] March Feb 9, 2021
@yunhaoling yunhaoling mentioned this issue Feb 9, 2021
Merged
@yunhaoling yunhaoling added the blocking-release Blocks release label Feb 11, 2021
@yunhaoling yunhaoling self-assigned this Feb 11, 2021
@yunhaoling
Copy link
Contributor Author

yunhaoling commented Feb 23, 2021 •
edited
Loading

Making the max_size_in_bytes a read-only property would be a breaking change which will break the existing pattern that some customers rely on -- updating the value of max_size_in_bytes of EventDataBatch object after EventDataBatch is created.

after discussion with arch, we decided to add a strong warning in the doc instead of introducing the breaking change -- PR is merged: #16644.

I'm closing this issue now.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jul 13, 2021
CodeGen from PR 14752 in Azure/azure-rest-api-specs
9040802 
Added new version in Microsoft.RecoveryServices and s360 fixups  (Azure#14752)

* Copied files to new version

* Changes in examples for new version

* Fixed typo in readme file

* Modified api version in json files

* Fixed the field name for user assigned identity

* Fixed the examples

* Fixing other examples

* Changed the tag in readme file for sdk generation

* Reverted the previous commit

* s360 fixups for Microsoft.RecoveryServices

* Added word in custom words

* Fixed the Semantic error for enum Move State

* Changing Object Id back to Principal Id

* Changing description in swagger

* Modified description and removed Inner error
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yunhaoling yunhaoling

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Milestone
[2021] March
Development

No branches or pull requests
1 participant
@yunhaoling