Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Pinned MinDependency on cryptography #19582

Closed
scbedd opened this issue Jun 29, 2021 · 1 comment
Closed

Remove Pinned MinDependency on cryptography #19582

scbedd opened this issue Jun 29, 2021 · 1 comment
Assignees
Labels
Azure.Identity Central-EngSys This issue is owned by the Engineering System team.

Comments

@scbedd
Copy link
Member

scbedd commented Jun 29, 2021

Essentially, this PR was committed to enable a release.

Longer term, we definitely want to test the earlier version of crypto, but until we remove PyJWT, we won't be able to do that.

Description from @chlowell

In a nutshell, we have azure-identity -> cryptography and azure-identity -> msal -> PyJWT -> cryptography. Min cryptography is 2.1.4 for azure-identity but the latest PyJWT requires 3.3+ and will raise given < 3.2. So, mindependency can't pass. I think msal should drop PyJWT but in the meantime I need to pass mindependency. I could just raise azure-identity's min cryptography, that's ugly but I guess workable for a beta release

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 29, 2021
@chlowell chlowell self-assigned this Jun 29, 2021
@chlowell chlowell added Azure.Identity and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jun 29, 2021
@scbedd scbedd self-assigned this Jul 13, 2021
@scbedd
Copy link
Member Author

scbedd commented Jul 13, 2021

Charles did offline investigation on this, and discovered that the new pip resolver will do the right thing.

pip install msal==1.12.0 cryptography==2.1.4

pip 21.1.1
cryptography 2.1.4
msal 1.12.0
PyJWT 1.7.1

But 20.2 does not, at least on 3 (works on 2.7):

pip 20.2
cryptography 2.1.4
msal 1.12.0
PyJWT 2.1.0

So what we need to do is A) upgrade pip to 20.3, as that is the newest version that has the new resolver + still supports py27 and B) verify that the transitive deps install the way we want. Will be filing a draft PR to test this.

@scbedd scbedd added the Central-EngSys This issue is owned by the Engineering System team. label Jul 13, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue Jul 20, 2022
Review request for Microsoft.ContainerService to add version 2022-06-02-preview (Azure#19653)

* Adds base for updating Microsoft.ContainerService from version preview/2022-05-02-preview to version 2022-06-02-preview

* Updates readme

* Updates API version in new specs and examples

* update readmes (Azure#19422)

* Containerservice 2022 06 02 preview fleet (Azure#19541)

* add fleets and fleet members resource types

* remove clusterLocation

* wording

* don't flatten  hubprofile

* extra comma

* fix patch example

* Fix violated rule R4041 for 2022-06-02-preview managedCluster swagger (Azure#19582)

* remove useless directive

* fix R4041

* fix

* add node restriction to swagger (Azure#19587)

* aks fleet list credentials api (Azure#19559)

* add fleet list credential api

* tweaks

* fix example filename

* fix casing

* add resourceId on hubProfile

* drop the new field, keep it as internal field

* fix duplicate shema error

* different name for fleet credential results

* use xms-identifier on the array items

* prettier fi

Co-authored-by: Stephane Erbrech <stephane.erbrech@gmail.com>

* sterbrec - address fleet comments - Microsoft.ContainerService - 2022-06-02-preview (Azure#19783)

* address fleet comments

* add example for nadditional status code

* Add missing `x-ms-long-running-operation-options` for delete operations in fleet-related API (Azure#19787)

* add final-state-via

* fix final state to location header

Co-authored-by: Stéphane Erbrech <stephane.erbrech@gmail.com>
Co-authored-by: lht6 <46062996+lht6@users.noreply.github.com>
Co-authored-by: Haitao Chen <haitch@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

No branches or pull requests

3 participants