Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python app to distributed tracing sample app #19971

Closed
lmolkova opened this issue Jul 28, 2021 · 0 comments
Closed

Add python app to distributed tracing sample app #19971

lmolkova opened this issue Jul 28, 2021 · 0 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)

Comments

@lmolkova
Copy link
Member

lmolkova commented Jul 28, 2021

We're working on distributed tracing sample app between azure sdk and azure monitor. We want to publish it on Azure-Samples and let users play with it. It's also a reasonable test bed for us to test how instrumentation integrates with typical user apps and OTel ecosystem.

Here's a brief plan (internal only) and draft with .NET and Java

Adding new service

  • add HTTP controller, it doesn't have to do anything for now
  • add EventHub consumer: pick a typical way to integrate with EventHub
    • e.g. Java supports messaging through Java APIs, maybe there is something similar in Python?
    • or just use vanilla EventHub SDK with handler
    • use checkpointing with Storage
  • Add OpenTelemetry
    • setup OpenTelemtey
    • enable applicable set of auto-instrumentation, make sure to enable popular HTTP clients (including one in Azure SDK), web framework that you use
    • enable Azure SDK collection if needed
    • based on configuration (TELEMETRY_DESTINATION env var), configure either
      • Azure Monitor exporter (Python)
      • or Jaeger

Try to be as idiomatic as possible

  • write code as users would do it, assume no manual telemetry collection/context propagation is needed
  • pick typical (web) frameworks as users would have
  • configuration should be done through dockerfiles, docker-compose and .env files only

App Logic

  • App should respond to HTTP server calls
  • App should consume messages through EventHub and checkpoint them.
  • App should also produce and send messages to ServiceBus.

Add app into the draft repo

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 28, 2021
@lmolkova lmolkova added Client This issue points to a problem in the data-plane of the library. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jul 28, 2021
@rakshith91 rakshith91 added the Monitor Monitor, Monitor Ingestion, Monitor Query label Aug 4, 2021
@rakshith91 rakshith91 added this to the [2021] September milestone Aug 4, 2021
@rakshith91 rakshith91 removed this from the [2021] December milestone Jan 20, 2022
@lmolkova lmolkova added the OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific) label Jun 16, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue Aug 18, 2022
Review request for Microsoft.ContainerService to add version 2022-07-02-preview (Azure#20062)

* Adds base for updating Microsoft.ContainerService from version preview/2022-06-02-preview to version 2022-07-02-preview

* Updates readme

* Updates API version in new specs and examples

* update readmes (Azure#19872)

* Add example of Azure KeyVault Secrets Provider Addon for 2022-07-02-preview (Azure#19874)

* add example of kv secret provider addon

* fix

* fix lint

* move ADH GA type to preview (Azure#19904)

* move ADH GA type to preview

* fix prettier check issue

* add overlay vpa swagger (Azure#19936)

* add overlay vpa objects

* fix typo

* address comments

Co-authored-by: zhifanhui <zhifanhui@microsoft.com>

* Swagger API for Operation Abort (Azure#19971)

* Swagger API for Operation Abort

* Swagger changes updates for Abort operation based on validations

* Haitao/secured by perimeter0702 (Azure#19873)

* add SecuredByPerimeter in publicNetworkAccess

* update enum value descriptions

* Add support for ImageCleaner on AKS (Azure#19916)

* Add support for ImageCleaner on AKS

* add more context in ImageCleaner description

* add default for availableAgentPoolVersions (Azure#19902)

* Add Azure Monitor Metrics (Prometheus) Profile (Azure#19965)

* Add Azure Monitor Metrics (Prometheus) Profile

* spelling error

* restructure to names from rp

* commit to rerun build

* ksm metrics

Co-authored-by: Jianping Zeng <zjpjack@users.noreply.github.com>
Co-authored-by: huizhifan <60024380+huizhifan@users.noreply.github.com>
Co-authored-by: zhifanhui <zhifanhui@microsoft.com>
Co-authored-by: InduSridhar <InduSridhar@users.noreply.github.com>
Co-authored-by: Haitao Chen <haitch@users.noreply.github.com>
Co-authored-by: jiashun0011 <573255300@qq.com>
Co-authored-by: bragi92 <kadubey@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)
Projects
None yet
Development

No branches or pull requests

2 participants