Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confidentialledger] mypy: function has duplicate type signatures #23356

Closed
kristapratico opened this issue Mar 5, 2022 · 1 comment · Fixed by #24900
Closed

[confidentialledger] mypy: function has duplicate type signatures #23356

kristapratico opened this issue Mar 5, 2022 · 1 comment · Fixed by #24900
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Confidential Ledger

Comments

@kristapratico
Copy link
Member

There are duplicate type signatures present in this init which prevents mypy from continuing to run checks:

def __init__(
self,
transaction_id, # type: str
receipt, # type: List[int]
):
# type: (int, List[int]) -> None

This prevents customers from getting typing information from the package.

This is reproducible by running mypy==0.931 at the package level directory:

azure-sdk-for-python\sdk\confidentialledger\azure-confidentialledger>python -m mypy ./azure
azure\confidentialledger\_models.py:291: error: Function has duplicate type signatures
Found 1 error in 1 file (errors prevented further checking)
@kristapratico kristapratico added Client This issue points to a problem in the data-plane of the library. Confidential Ledger labels Mar 5, 2022
@lynshi
Copy link
Contributor

lynshi commented Mar 22, 2022

I've created this PR to resolve the issue. Please let me know if there's any further changes required!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Confidential Ledger
Projects
None yet
2 participants