[Confidential Ledger] GA Data Plane SDK #24900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
reviewed
Jul 13, 2022
sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_operations/_patch.py
Show resolved
Hide resolved
iscai-msft
reviewed
Jul 14, 2022
sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_patch.py
Show resolved
Hide resolved
...nfidentialledger/azure-confidentialledger/azure/confidentialledger/aio/_operations/_patch.py
Show resolved
Hide resolved
sdk/confidentialledger/azure-confidentialledger/samples/verify_service_async.py
Show resolved
Hide resolved
sdk/confidentialledger/azure-confidentialledger/samples/verify_service_async.py
Outdated
Show resolved
Hide resolved
|
/azp run python - confidentialledger - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - confidentialledger - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - confidentialledger - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - confidentialledger - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - confidentialledger - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
iscai-msft
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
looks good to me, congrats @lynshi for all of your hard work!
annatisch
reviewed
Jul 18, 2022
sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_patch.py
Outdated
Show resolved
Hide resolved
sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_patch.py
Outdated
Show resolved
Hide resolved
sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/aio/_patch.py
Outdated
Show resolved
Hide resolved
...confidentialledger/azure-confidentialledger/azure/confidentialledger/certificate/_version.py
Show resolved
Hide resolved
sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/certificate/_patch.py
Show resolved
Hide resolved
iscai-msft
added a commit
that referenced
this pull request
Jul 20, 2022
…into version_tolerant_models * 'main' of https://github.com/Azure/azure-sdk-for-python: (259 commits) Sync eng/common directory with azure-sdk-tools for PR 3702 (#25309) remove continuation_token kwarg (#25298) Print additional result summary formats to pipelines UI (#25306) Increment package version after release of azure-ai-language-questionanswering (#25303) [textanalytics] refactor pollers + add TA poller protocol (#25275) Remove needs-triage label if it is assigned (#25302) Update casing for 'verison' (#25197) don't drop 3.6 yet (#25293) always check proxy availability (#25291) bump python version in autorest pipeline check (#25288) add needs-triage labeler (#25289) [Confidential Ledger] GA Data Plane SDK (#24900) [QA] support AAD auth (#25256) Fixed the var name (#25277) Storage File Datalake test (test_list_paths_with_max_per_page) improvement (#25240) [formrecognizer] Add a type for target authorization for copy requests (#25268) disable labeler (#25278) [textanalytics] use commits for swagger in generation readme (#25246) [textanalytics] add multi label classify bespoke method (#25009) [Storage] Migrate `test_blob_api_version` and `test_blob_client` to test proxy (#25272) ...
jeremydvoss
pushed a commit
to jeremydvoss/azure-sdk-for-python
that referenced
this pull request
Jul 21, 2022
* remove duplicate typing * update version and changelog * added confidentialledger to tox list and fix issues * always import typing * update date in changelog * fix trailing whitespace * remove TransactionStatus model * align get_ledger_entry backoff config api with azure defaults * update typing for ConfidentialLedgerCertificateCredential * dpg generation for new version * small updates * add pytest configuration * wip * the tests ran * tested identity service client and added test for add cert-based user * change identity in test * passed non-async tests * pass all tests and make recordings * totally generate using the old way * update swagger for stable api version * generate using stable and remove auth * update ConfidentialLedgerClient init * patch async init * overrode all expected client operations * overrode async * remove accidental file * attr -> json * fix typos * add https:// * fix imports and credential type checking * fix method name * credential to args * black * fix some tests * updated async tests * fixed entry for range query * generate identity service so it does not get overriden * skip url encoding of user id * generate with autorest python 5.17.0 * pass identity service tests * remove api version from tests * build in typical identity service uri * regenerated * update identity * Union[IO, JSON] * set content-type for create user and fix transaction status check in tests * fix tests * fix user tests * basic readme for samples * follow retry policy parameter names * remove post and wait * remove post_ledger_entry_wait_for_commit from test * Revert "remove post_ledger_entry_wait_for_commit from test" This reverts commit 3e4ad98. * Revert "remove post and wait" This reverts commit 5cb5b0b. * add cert user before starting * add test config files * remove unnecessary environment vars (set by the ARM template) * fix non-async test * GetLedgerEntryPollingMethod * StatePollingMethod * complete poller nonasync * AsyncLroPoller returned * tests to lro * tests use pollers * update arm template * rename module and add sample * update readme up to examples * update readme * list ledger entries readme and sample * finish readme * finish samples * update CHANGELOG * retrieve cert at startup * new recordings for identity service * check collection id * list collections * address pr comments * rename resource group variable per live test setup * ran black * remove ARM template * add user management samples * regenerate with fixed swagger * operations mixin for identity client * latest tests and recordings * use confidential ledger id * updated recordings * contextmanager for async samples * update changelog per comments * put imports in all readme samples * remove operation prefix in Swagger and regenerate * remove some examples from readme and start samples section * samples skeleton * run list_ledger_entries samples * updated manage users sample * get receipt sample * write to ledger * use collections * service verification samples * fix collections signature * add aiohttp to requirements * use uniqueString for ledger name * set resource location * update setup.py based on example * suppress credscan for test secret * fix super and credential attr * omit in toc is causing errors and also apparently not necessary locally anymore * update shared requirements * pylint fixes * no more self.assert * fix super * deduplicate pollingmethod * test fixes * update ledger name * shorten range query test and add delay to add user * greatly shorten range query test * redo recordings * add known word to cspell * add PostTestSteps * reduce flakiness * add envvars * remove PostTestSteps * address edge cases in tests * autorest 6.0.1 * regenerate with batch * rerecord * add comment * better handling of cls in begin_post_ledger_entry * fix typo * fetch TLS certificate automagically * updated tests and README for new convenience TLS cert fetching * pass kwargs * fix credential typo * identity_service -> certificate * rename endpoint params * regen after review and passed tests and samples * regenerated with latest swagger * updated per pr comments * fix pylint * use tempfile.TemporaryDirectory * retry ResourceNotFoundError in poller * address review comments * uupdate release date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces the GA version of the Data Plane SDK for Confidential Ledger. Besides retagging for preview to stable, the Swagger has changed somewhat; for example, the
subLedgerIdfield has been renamed tocollectionId. The generated code is now generated by DPG, leading to the removal of models. Client methods now return JSON directly.This also fixes #23356 as all models have been removed with DPG generation.
Live testing of tests and samples is also included now.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines