Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[textanalytics] how should client-level default_language and auto-detect default_language coexist #26176

Closed
kristapratico opened this issue Sep 13, 2022 · 1 comment
Closed

[textanalytics] how should client-level default_language and auto-detect default_language coexist #26176

kristapratico opened this issue Sep 13, 2022 · 1 comment
Assignees
@kristapratico
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Language Cognitive - Text Analytics
Milestone
2022-11

Comments

@kristapratico
Copy link
Member

kristapratico commented Sep 13, 2022 •
edited
Loading

Azure/azure-sdk-for-js#23208 (comment)
@kristapratico kristapratico added Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics Cognitive - Language labels Sep 13, 2022
@kristapratico kristapratico self-assigned this Sep 13, 2022
@github-actions github-actions bot added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Sep 13, 2022
This was referenced Sep 13, 2022
Merged
Closed
@kristapratico kristapratico added this to the 2022-10 milestone Sep 14, 2022
@kristapratico kristapratico mentioned this issue Sep 14, 2022
Closed
@kristapratico
Copy link
Member Author

kristapratico commented Sep 15, 2022 •
edited
Loading

Okay took more than a minute to look at this and realized that "auto" is passed at a per-document level. So I think this will coexist nicely with our default_language at the client-level and our language at the client-method-level since these two options are just a short-cut for setting a per-document language for the user. My one thought is that we might want to rename the service's new defaultLanguage to something that will make more clear that this is the fall back language used IF autodetection is selected and the service fails to detect the language. Right now I think the name of this parameter is kind of confusing in context of what we already have in the client libraries.

@kristapratico kristapratico mentioned this issue Sep 20, 2022
Merged
@kristapratico kristapratico modified the milestones: 2022-10, 2022-11 Sep 29, 2022
Repository owner moved this from In Progress to Done in Azure SDK for Cognitive Services - Language Oct 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kristapratico kristapratico

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Language Cognitive - Text Analytics
Projects
Azure SDK for Cognitive Services - Language
Status: Done
Milestone
2022-11
Development

No branches or pull requests
1 participant
@kristapratico