[Language Text] Add support for v2022-10-01-preview #23208

deyaaeldeen · 2022-09-13T15:27:47Z

Adds support for v2022-10-01-preview along with samples, see the changelog entry for a list of new features. Tests will be added in another PR when the deployment is ready.

Issues:
#23197
#23198
#23199
#23200
#23201
#23238

kristapratico

Is 2022-10-01-preview not deployed yet / should we target a feature branch for now?

sdk/cognitivelanguage/ai-language-text/README.md

sdk/cognitivelanguage/ai-language-text/review/ai-language-text.api.md

sdk/cognitivelanguage/ai-language-text/samples-dev/healthcare.ts

azure-sdk · 2022-09-13T18:43:01Z

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-language-text

heaths · 2022-09-13T19:45:05Z

sdk/cognitivelanguage/ai-language-text/CHANGELOG.md


 ### Features Added

+- Supports service version 2022-10-01-preview by default instead of 2022-05-01.
+- Adds back support for extractive summarization and FHIR.


"Adds back" assumes they've read the entire changelog up till now. Doesn't seem important. Probably just "Adds support for" like all the others.

Addressed in 538c4c6

sdk/cognitivelanguage/ai-language-text/README.md

heaths · 2022-09-13T19:48:39Z

sdk/cognitivelanguage/ai-language-text/README.md

@@ -2,7 +2,7 @@

 [Azure Cognitive Service for Language](https://azure.microsoft.com/services/cognitive-services/language-service/) is a cloud-based service that provides advanced natural language processing over raw text, and includes the following main features:

-**Note:** This SDK targets Azure Cognitive Service for Language API version 2022-05-01.
+**Note:** This SDK targets Azure Cognitive Service for Language API version 2022-10-01-preview.

 - Language Detection


Given how long this list is, if we're going to keep putting every feature our SDK supports in the README, we should probably start making these links to bookmarks. GitHub does generate a TOC, but it's hidden and, in my experience, not a lot of people know about it. Besides, some of these READMEs get rendered in package repo sites across different languages. Bookmarks should still work there.

/cc @kristapratico @joseharriaga @mayurid @mssfang

By "links to bookmarks" do you mean linked to the service docs pages?

No, e.g.,

- [link text](#link-bookmark) ## Link Bookmark

Headings are automatically transformed into slugs, though with words like "a", "an", "the", etc., some renderers remove them. If that's a concern, be explicit:

## A Link Bookmark<a name="link-bookmark"></a>

My worry is that with so many features - and always more - with code snippets, the README is getting so large it's harder to navigate and quite overwhelming without either breaking it up, or at least making it easier to jump to interesting sections for the reader.

Yeah agreed, we got this feedback awhile back: Azure/azure-sdk-for-python#19435 (from Johan IIRC). In Python, we haven't been adding a Readme example with every new feature, instead we link out specifically to the sample. edit -- under the Examples section, though, not under the first header

Good points, I guess the main question here is how to present all the features on an equal footing and still be short and sweet. How does everyone feel about Python's?

I opened #23242 to track this.

sdk/cognitivelanguage/ai-language-text/review/ai-language-text.api.md

heaths · 2022-09-13T19:52:41Z

sdk/cognitivelanguage/ai-language-text/swagger/README.md

@@ -12,9 +12,9 @@ generate-metadata: false
 license-header: MICROSOFT_MIT_NO_VERSION
 output-folder: ../
 source-code-folder-path: ./src/generated
-input-file: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cognitiveservices/data-plane/Language/stable/2022-05-01/analyzetext.json
+input-file: https://github.com/Azure/azure-rest-api-specs/blob/main/dev/cognitiveservices/data-plane/Language/analyzetext.json


They are in the process of moving this, but in your autorest configuration you should always use a commit. Branch and tags can move, and branches most definitely will move.

Addressed in 538c4c6

sdk/cognitivelanguage/ai-language-text/swagger/README.md

kristapratico

Updates LGTM

sdk/cognitivelanguage/ai-language-text/src/transforms.ts

sdk/cognitivelanguage/ai-language-text/src/textAnalysisClient.ts

sdk/cognitivelanguage/ai-language-text/src/models.ts

…23673) The work has been reviewed in the following PRs: #23208 #23465 #23510 #23525 #23589 #23564 #23619 Live run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1959799&view=results

Update readme.python.md (Azure#23208)

Review request for Microsoft.ContainerInstance to add version stable/2023-05-01 (Azure#23485) * Adds base for updating Microsoft.ContainerInstance from version preview/2022-10-01-preview to version 2023-05-01 * Updates readme * Updates API version in new specs and examples * add container security context property * update readme tag to previous stable version * add example with security context * avocado fix default tag should contain all endpoints * add back spot priority changes * use previous stable version as default tag * prettier fix * use spaces * add container security context property * update readme tag to previous stable version * add example with security context * avocado fix default tag should contain all endpoints * add back spot priority changes * use previous stable version as default tag * prettier fix * use spaces * fix error * use spaces * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23166) * add container security context property * update readme tag to previous stable version * add example with security context * avocado fix default tag should contain all endpoints * add back spot priority changes * use previous stable version as default tag * prettier fix * use spaces * fix error * use spaces * fix CI errors * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23169) * add container security context property * update readme tag to previous stable version * add example with security context * avocado fix default tag should contain all endpoints * add back spot priority changes * use previous stable version as default tag * prettier fix * use spaces * fix error * use spaces * fix CI errors * use altest api version as default for Avocado * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23170) * add container security context property * update readme tag to previous stable version * add example with security context * avocado fix default tag should contain all endpoints * add back spot priority changes * use previous stable version as default tag * prettier fix * use spaces * fix error * use spaces * fix CI errors * use altest api version as default for Avocado * update host to eastus2euap endpoint to check manifest * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23452) * add container security context property * update readme tag to previous stable version * add example with security context * avocado fix default tag should contain all endpoints * add back spot priority changes * use previous stable version as default tag * prettier fix * use spaces * fix error * use spaces * fix CI errors * use altest api version as default for Avocado * update host to eastus2euap endpoint to check manifest * use old api versionf or operations * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23453) * add container security context property * update readme tag to previous stable version * add example with security context * avocado fix default tag should contain all endpoints * add back spot priority changes * use previous stable version as default tag * prettier fix * use spaces * fix error * use spaces * fix CI errors * use altest api version as default for Avocado * update host to eastus2euap endpoint to check manifest * use old api versionf or operations * revert Operations example api version * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23471) * add container security context property * update readme tag to previous stable version * add example with security context * avocado fix default tag should contain all endpoints * add back spot priority changes * use previous stable version as default tag * prettier fix * use spaces * fix error * use spaces * fix CI errors * use altest api version as default for Avocado * update host to eastus2euap endpoint to check manifest * use old api versionf or operations * revert Operations example api version * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23473) * add container security context property * update readme tag to previous stable version * add example with security context * avocado fix default tag should contain all endpoints * add back spot priority changes * use previous stable version as default tag * prettier fix * use spaces * fix error * use spaces * fix CI errors * use altest api version as default for Avocado * update host to eastus2euap endpoint to check manifest * MGRP S360 Vuln (Azure#22832) * Add blockchain to latest profile * Add additional types * Fix Swagger issues * Solve validation --------- Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> * use old api versionf or operations * Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441) * added example for the new field * updated the double ref that was causing build failure * Fixed PrometheusRuleGroups examples (Azure#23390) * Fixed PrometheusRuleGroups examples * One more fix * Remvoe flattern (Azure#23460) Co-authored-by: Will Huang <huangwill@microsoft.com> * Mvad update (Azure#23434) * Add default value 10 for topContributorCount * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings * Update TypeSpec config * Add back language emitter options * Fix cspell and model validation errors --------- Co-authored-by: Chunlei Wang <chuwan@microsoft.com> * revert Operations example api version --------- Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com> Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com> Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com> Co-authored-by: will <koyasu221b@gmail.com> Co-authored-by: Will Huang <huangwill@microsoft.com> Co-authored-by: Mike Kistler <mikekistler@microsoft.com> Co-authored-by: Chunlei Wang <chuwan@microsoft.com> * use management.auzre.com endpoint * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23483) * add container security context property * update readme tag to previous stable version * add example with security context * avocado fix default tag should contain all endpoints * add back spot priority changes * use previous stable version as default tag * prettier fix * use spaces * fix error * use spaces * fix CI errors * use altest api version as default for Avocado * update host to eastus2euap endpoint to check manifest * MGRP S360 Vuln (Azure#22832) * Add blockchain to latest profile * Add additional types * Fix Swagger issues * Solve validation --------- Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> * use old api versionf or operations * Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441) * added example for the new field * updated the double ref that was causing build failure * Fixed PrometheusRuleGroups examples (Azure#23390) * Fixed PrometheusRuleGroups examples * One more fix * Remvoe flattern (Azure#23460) Co-authored-by: Will Huang <huangwill@microsoft.com> * Mvad update (Azure#23434) * Add default value 10 for topContributorCount * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings * Update TypeSpec config * Add back language emitter options * Fix cspell and model validation errors --------- Co-authored-by: Chunlei Wang <chuwan@microsoft.com> * revert Operations example api version * use management.auzre.com endpoint --------- Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com> Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com> Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com> Co-authored-by: will <koyasu221b@gmail.com> Co-authored-by: Will Huang <huangwill@microsoft.com> Co-authored-by: Mike Kistler <mikekistler@microsoft.com> Co-authored-by: Chunlei Wang <chuwan@microsoft.com> * fix package version in readme * Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23484) * add container security context property * update readme tag to previous stable version * add example with security context * avocado fix default tag should contain all endpoints * add back spot priority changes * use previous stable version as default tag * prettier fix * use spaces * fix error * use spaces * fix CI errors * use altest api version as default for Avocado * update host to eastus2euap endpoint to check manifest * MGRP S360 Vuln (Azure#22832) * Add blockchain to latest profile * Add additional types * Fix Swagger issues * Solve validation --------- Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> * use old api versionf or operations * Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441) * added example for the new field * updated the double ref that was causing build failure * Fixed PrometheusRuleGroups examples (Azure#23390) * Fixed PrometheusRuleGroups examples * One more fix * Remvoe flattern (Azure#23460) Co-authored-by: Will Huang <huangwill@microsoft.com> * Mvad update (Azure#23434) * Add default value 10 for topContributorCount * Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings * Update TypeSpec config * Add back language emitter options * Fix cspell and model validation errors --------- Co-authored-by: Chunlei Wang <chuwan@microsoft.com> * revert Operations example api version * add codeowners for Compute Instance swagger (Azure#23437) Co-authored-by: Naman Agarwal <naagarw@microsoft.com> * [Hub Generated] Review request for Microsoft.DevHub to add version preview/2022-10-11-preview (Azure#22828) * Adds base for updating Microsoft.DevHub from version preview/2022-04-01-preview to version 2022-10-11-preview * Updates readme * Updates API version in new specs and examples * start 10-11 preview * add words * fix readme version * update swagger version * add second putworkflow example * fix generatepreviewartifactsresponse * align generate preview artifacts example * update param locations that got changed * add x-ms-client-flatten for artifact properties * Adding WorkflowRunStatus * Fixing enum name * add namespace to example --------- Co-authored-by: Brandon Foley <brandonfoley13@gmail.com> * Update readme.python.md (Azure#23208) * fixing async response type for machinelearningservices-2023-02-01-preview (Azure#23105) * fixing regex pattern and async response type * remove update to regex * Fix lint error for Datadog RP (Azure#23477) * Fix link error for Datadog RP * Fix version * merging billing fix to public repo (Azure#23424) Co-authored-by: Gaurav Bang <gauravbang@microsoft.com> * use management.auzre.com endpoint * fix package version in readme --------- Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com> Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com> Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com> Co-authored-by: will <koyasu221b@gmail.com> Co-authored-by: Will Huang <huangwill@microsoft.com> Co-authored-by: Mike Kistler <mikekistler@microsoft.com> Co-authored-by: Chunlei Wang <chuwan@microsoft.com> Co-authored-by: Naman Agarwal <namanag16@gmail.com> Co-authored-by: Naman Agarwal <naagarw@microsoft.com> Co-authored-by: David Gamero <david340804@gmail.com> Co-authored-by: Brandon Foley <brandonfoley13@gmail.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Karishma Daga <karishmadaga@microsoft.com> Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com> Co-authored-by: Gaurav <bang.gourav@gmail.com> Co-authored-by: Gaurav Bang <gauravbang@microsoft.com> * fix tag in readme * update example with capabilities example * fix typo --------- Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com> Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com> Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com> Co-authored-by: will <koyasu221b@gmail.com> Co-authored-by: Will Huang <huangwill@microsoft.com> Co-authored-by: Mike Kistler <mikekistler@microsoft.com> Co-authored-by: Chunlei Wang <chuwan@microsoft.com> Co-authored-by: Naman Agarwal <namanag16@gmail.com> Co-authored-by: Naman Agarwal <naagarw@microsoft.com> Co-authored-by: David Gamero <david340804@gmail.com> Co-authored-by: Brandon Foley <brandonfoley13@gmail.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Karishma Daga <karishmadaga@microsoft.com> Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com> Co-authored-by: Gaurav <bang.gourav@gmail.com> Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>

[Language Text] Add support for Ignite features

52b832c

deyaaeldeen requested review from heaths, kristapratico and mssfang September 13, 2022 15:27

deyaaeldeen requested review from bterlson, xirzec and jeremymeng as code owners September 13, 2022 15:27

kristapratico reviewed Sep 13, 2022

View reviewed changes

deyaaeldeen changed the title ~~[Language Text] Add support for Ignite features~~ [Language Text] Add support for v2022-10-01-preview Sep 13, 2022

kristapratico mentioned this pull request Sep 13, 2022

[textanalytics] how should client-level default_language and auto-detect default_language coexist Azure/azure-sdk-for-python#26176

Closed

deyaaeldeen added 2 commits September 13, 2022 11:09

address feedback

3d71382

fix dep version

86aa77e

heaths reviewed Sep 13, 2022

View reviewed changes

deyaaeldeen changed the base branch from main to feature/ai-language-text@1.1 September 13, 2022 20:44

deyaaeldeen added 2 commits September 15, 2022 17:28

merge upstream/main

424334f

add support for entity resolution and address feedback

538c4c6

deyaaeldeen requested review from ckairen, benbp, mikeharder, weshaggard, joheredi, EmmaZhu, XiaoningLiu, vinjiang, jiacfan, ljian3377, HarshaNalluru, timovv and KarishmaGhiya as code owners September 16, 2022 01:00

deyaaeldeen removed request for XiaoningLiu, vinjiang, jeremymeng, ljian3377, KarishmaGhiya, weshaggard, mikeharder, HarshaNalluru, schaabs, jiacfan, joheredi, ckairen and witemple-msft September 16, 2022 01:01

address feedback

2ea10ea

deyaaeldeen requested a review from joseharriaga September 16, 2022 22:46

kristapratico approved these changes Sep 16, 2022

View reviewed changes