Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrity Checks #23473

Closed
elizabethhalper opened this issue Oct 11, 2022 · 5 comments
Closed

Integrity Checks #23473

elizabethhalper opened this issue Oct 11, 2022 · 5 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files)
Milestone

Comments

@elizabethhalper
Copy link

Is your feature request related to a problem? Please describe.
We have multiple customers who are asking that integrity checks are performed on data transferred to and from blob storage.
We have learned from an engineer on this SDK team that "the SDK itself doesn't do any integrity checks. Storage service provided integrity checks properties, you can save checksums of the content in uploading and validate the content checksum in downloading."

Describe the solution you'd like
We'd like there to be integrity checks within the SDK itself

Describe alternatives you've considered
We've considered saving the checksums of the properties, however, the customer leverages multiple Azure SDK's, some of which do integrity checks and others that don't so it would be inconsistent within their service.

Additional context
Add any other context or screenshots about the feature request here.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 11, 2022
@azure-sdk azure-sdk added Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. Storage Storage Service (Queues, Blobs, Files) labels Oct 11, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 11, 2022
@xirzec xirzec added the feature-request This issue requires a new behavior in the product in order be resolved. label Oct 11, 2022
@xirzec xirzec removed the needs-team-triage Workflow: This issue needs the team to triage. label Oct 11, 2022
@xirzec
Copy link
Member

xirzec commented Oct 11, 2022

@elizabethhalper If I understand you correctly, is the request that the SDK validate blob contents were uploaded successfully and provide some kind of thrown error if this doesn't happen from the upload operations?

@EmmaZhu EmmaZhu added this to the Backlog milestone Oct 12, 2022
@EmmaZhu
Copy link
Member

EmmaZhu commented Oct 12, 2022

@elizabethhalper ,

There are two levels of integrity, using uploading as an example:

  1. Transactional integrity check: this could be used in PageBlobClient.uploadPages, BlockBlobClient.stageBlock, AppendBlobClient.appendBlock. There's a header to set checksum for a request, storage service will compare the checksum in the header with the one it calculated from the request body and throw out an error if not match.
  2. Whole file content integrity check: this could be used in interfaces like: BlockBlobClient.upload, BlockBlobClient.uploadFile.
    Customer could put a checksum for the whole file content in blob's properties. When downloading the blob, customer can check the checksum in properties with the one calculated from the downloaded content.

From customer's scenario, which way would customer need?

@sachabrants
Copy link

We use BlockBlobClient.uploadData

Could that be prioritized?

@EmmaZhu
Copy link
Member

EmmaZhu commented Oct 13, 2022

I have add the feature request into backlog, and we'd need to discuss about the feature internally.

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Apr 13, 2023
Review request for Microsoft.ContainerInstance to add version stable/2023-05-01 (Azure#23485)

* Adds base for updating Microsoft.ContainerInstance from version preview/2022-10-01-preview to version 2023-05-01

* Updates readme

* Updates API version in new specs and examples

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23166)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23169)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23170)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23452)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* use old api versionf or operations

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23453)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* use old api versionf or operations

* revert Operations example api version

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23471)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* use old api versionf or operations

* revert Operations example api version

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23473)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* MGRP S360 Vuln (Azure#22832)

* Add blockchain to latest profile

* Add additional types

* Fix Swagger issues

* Solve validation

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>

* use old api versionf or operations

* Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441)

* added example for the new field

* updated the double ref that was causing build failure

* Fixed PrometheusRuleGroups examples (Azure#23390)

* Fixed PrometheusRuleGroups examples

* One more fix

* Remvoe flattern (Azure#23460)

Co-authored-by: Will Huang <huangwill@microsoft.com>

* Mvad update (Azure#23434)

* Add default value 10 for topContributorCount

* Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings

* Update TypeSpec config

* Add back language emitter options

* Fix cspell and model validation errors

---------

Co-authored-by: Chunlei Wang <chuwan@microsoft.com>

* revert Operations example api version

---------

Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
Co-authored-by: will <koyasu221b@gmail.com>
Co-authored-by: Will Huang <huangwill@microsoft.com>
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Co-authored-by: Chunlei Wang <chuwan@microsoft.com>

* use management.auzre.com endpoint

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23483)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* MGRP S360 Vuln (Azure#22832)

* Add blockchain to latest profile

* Add additional types

* Fix Swagger issues

* Solve validation

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>

* use old api versionf or operations

* Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441)

* added example for the new field

* updated the double ref that was causing build failure

* Fixed PrometheusRuleGroups examples (Azure#23390)

* Fixed PrometheusRuleGroups examples

* One more fix

* Remvoe flattern (Azure#23460)

Co-authored-by: Will Huang <huangwill@microsoft.com>

* Mvad update (Azure#23434)

* Add default value 10 for topContributorCount

* Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings

* Update TypeSpec config

* Add back language emitter options

* Fix cspell and model validation errors

---------

Co-authored-by: Chunlei Wang <chuwan@microsoft.com>

* revert Operations example api version

* use management.auzre.com endpoint

---------

Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
Co-authored-by: will <koyasu221b@gmail.com>
Co-authored-by: Will Huang <huangwill@microsoft.com>
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Co-authored-by: Chunlei Wang <chuwan@microsoft.com>

* fix package version in readme

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23484)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* MGRP S360 Vuln (Azure#22832)

* Add blockchain to latest profile

* Add additional types

* Fix Swagger issues

* Solve validation

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>

* use old api versionf or operations

* Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441)

* added example for the new field

* updated the double ref that was causing build failure

* Fixed PrometheusRuleGroups examples (Azure#23390)

* Fixed PrometheusRuleGroups examples

* One more fix

* Remvoe flattern (Azure#23460)

Co-authored-by: Will Huang <huangwill@microsoft.com>

* Mvad update (Azure#23434)

* Add default value 10 for topContributorCount

* Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings

* Update TypeSpec config

* Add back language emitter options

* Fix cspell and model validation errors

---------

Co-authored-by: Chunlei Wang <chuwan@microsoft.com>

* revert Operations example api version

* add codeowners for Compute Instance swagger (Azure#23437)

Co-authored-by: Naman Agarwal <naagarw@microsoft.com>

* [Hub Generated] Review request for Microsoft.DevHub to add version preview/2022-10-11-preview (Azure#22828)

* Adds base for updating Microsoft.DevHub from version preview/2022-04-01-preview to version 2022-10-11-preview

* Updates readme

* Updates API version in new specs and examples

* start 10-11 preview

* add words

* fix readme version

* update swagger version

* add second putworkflow example

* fix generatepreviewartifactsresponse

* align generate preview artifacts example

* update param locations that got changed

* add x-ms-client-flatten for artifact properties

* Adding WorkflowRunStatus

* Fixing enum name

* add namespace to example

---------

Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>

* Update readme.python.md (Azure#23208)

* fixing async response type for machinelearningservices-2023-02-01-preview (Azure#23105)

* fixing regex pattern and async response type

* remove update to regex

* Fix lint error for Datadog RP (Azure#23477)

* Fix link error for Datadog RP

* Fix version

* merging billing fix to public repo (Azure#23424)

Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>

* use management.auzre.com endpoint

* fix package version in readme

---------

Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
Co-authored-by: will <koyasu221b@gmail.com>
Co-authored-by: Will Huang <huangwill@microsoft.com>
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
Co-authored-by: Naman Agarwal <namanag16@gmail.com>
Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
Co-authored-by: David Gamero <david340804@gmail.com>
Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
Co-authored-by: Gaurav <bang.gourav@gmail.com>
Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>

* fix tag in readme

* update example with capabilities example

* fix typo

---------

Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
Co-authored-by: will <koyasu221b@gmail.com>
Co-authored-by: Will Huang <huangwill@microsoft.com>
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
Co-authored-by: Naman Agarwal <namanag16@gmail.com>
Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
Co-authored-by: David Gamero <david340804@gmail.com>
Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
Co-authored-by: Gaurav <bang.gourav@gmail.com>
Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
Copy link

Hi @elizabethhalper, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

5 participants