Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS error with Azure Communication Services SDK #23390

Closed
1 task done
dstarn1 opened this issue Oct 3, 2022 · 5 comments
Closed
1 task done

CORS error with Azure Communication Services SDK #23390

dstarn1 opened this issue Oct 3, 2022 · 5 comments
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Communication - Calling Server Communication - Identity customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@dstarn1
Copy link

dstarn1 commented Oct 3, 2022

  • Package Name:
  • "@azure/communication-calling": "^1.6.3",
    "@azure/communication-common": "^2.1.0",
  • Package Version:
  • Operating system:
  • nodejs
    • version:
    • node v18.8.0
  • [x ] browser
    • name/version:
    • Google Chrome version 105.0.5195.127

Describe the bug
A clear and concise description of what the bug is.

I am using the Azure Communication Services SDK for Javascript to create a voice call web app in Google Chrome following the quickstart:

https://learn.microsoft.com/en-us/azure/communication-services/quickstarts/voice-video-calling/getting-started-with-calling?pivots=platform-web

The code in question is as follows:

  submitToken.addEventListener("click",` async () => {

  const callClient = new CallClient();
  const userTokenCredential = userToken.value;
   
try {
      tokenCredential = new AzureCommunicationTokenCredential(userTokenCredential);
      callAgent = await callClient.createCallAgent(tokenCredential);
 }...

When I enter the user access token in input box in the browser, the AzureCommunicationTokenCredential is instantiated and I generate the following errors in the dev-tools console in Chrome:

sdk.bundle.js:109 ECS - Config fetch complete
sdk.bundle.js:109 ECS - Delaying User config fetch until we have a valid SkypeToken
sdk.bundle.js:109 ECS - Config fetch complete
synthesis.html:1 Access to XMLHttpRequest at 'https://edge.skype.com/trap/tokens' from origin 'null' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.
sdk.bundle.js:92          GET https://edge.skype.com/trap/tokens net::ERR_FAILED

Expected behavior
Typically this process would have no errors and would allow me to make a phone call as the user access token would have been validated.

Anyone have any ideas?

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Oct 3, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Communication:0.52517945,Azure.Identity:0.44786534,Azure.Core:0.010602847'

@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 3, 2022
@jeremymeng jeremymeng added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 5, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Communication:0.52517945,Azure.Identity:0.44786534,Azure.Core:0.010602847'

@xirzec xirzec added Communication - Calling Server Client This issue points to a problem in the data-plane of the library. labels Oct 5, 2022
@ghost ghost added needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Oct 5, 2022
@akania
Copy link
Member

akania commented Oct 5, 2022

Hi @dstarn1 , can you please share more information - a request ( with headers ) would help - you can remove personal information if there's one ( IPs etc.. )

@dstarn1
Copy link
Author

dstarn1 commented Oct 14, 2022

Hi @akania , apologies for the delay.

I had to reup my subscription so my errors have changed in the browser. Here is what now shows:
image
image

It seems like the errors with the SDK making the request to 'https://edge.skype.com/trap/tokens' is now successful with a 200 response but now I'm getting continuous errors about cookies seen below:

image

Not sure what to make of it. The only pending request is the websocket request with the following info:

image

@xirzec xirzec added bug This issue requires a change to an existing behavior in the product in order to be resolved. Service Attention Workflow: This issue is responsible by Azure service team. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 30, 2023
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Apr 13, 2023
Review request for Microsoft.ContainerInstance to add version stable/2023-05-01 (Azure#23485)

* Adds base for updating Microsoft.ContainerInstance from version preview/2022-10-01-preview to version 2023-05-01

* Updates readme

* Updates API version in new specs and examples

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23166)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23169)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23170)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23452)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* use old api versionf or operations

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23453)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* use old api versionf or operations

* revert Operations example api version

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23471)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* use old api versionf or operations

* revert Operations example api version

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23473)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* MGRP S360 Vuln (Azure#22832)

* Add blockchain to latest profile

* Add additional types

* Fix Swagger issues

* Solve validation

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>

* use old api versionf or operations

* Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441)

* added example for the new field

* updated the double ref that was causing build failure

* Fixed PrometheusRuleGroups examples (Azure#23390)

* Fixed PrometheusRuleGroups examples

* One more fix

* Remvoe flattern (Azure#23460)

Co-authored-by: Will Huang <huangwill@microsoft.com>

* Mvad update (Azure#23434)

* Add default value 10 for topContributorCount

* Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings

* Update TypeSpec config

* Add back language emitter options

* Fix cspell and model validation errors

---------

Co-authored-by: Chunlei Wang <chuwan@microsoft.com>

* revert Operations example api version

---------

Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
Co-authored-by: will <koyasu221b@gmail.com>
Co-authored-by: Will Huang <huangwill@microsoft.com>
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Co-authored-by: Chunlei Wang <chuwan@microsoft.com>

* use management.auzre.com endpoint

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23483)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* MGRP S360 Vuln (Azure#22832)

* Add blockchain to latest profile

* Add additional types

* Fix Swagger issues

* Solve validation

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>

* use old api versionf or operations

* Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441)

* added example for the new field

* updated the double ref that was causing build failure

* Fixed PrometheusRuleGroups examples (Azure#23390)

* Fixed PrometheusRuleGroups examples

* One more fix

* Remvoe flattern (Azure#23460)

Co-authored-by: Will Huang <huangwill@microsoft.com>

* Mvad update (Azure#23434)

* Add default value 10 for topContributorCount

* Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings

* Update TypeSpec config

* Add back language emitter options

* Fix cspell and model validation errors

---------

Co-authored-by: Chunlei Wang <chuwan@microsoft.com>

* revert Operations example api version

* use management.auzre.com endpoint

---------

Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
Co-authored-by: will <koyasu221b@gmail.com>
Co-authored-by: Will Huang <huangwill@microsoft.com>
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Co-authored-by: Chunlei Wang <chuwan@microsoft.com>

* fix package version in readme

* Fnuarnav containerinstance microsoft.container instance 2023 05 01 (Azure#23484)

* add container security context property

* update readme tag to previous stable version

* add example with security context

* avocado fix default tag should contain all endpoints

* add back spot priority changes

* use previous stable version as default tag

* prettier fix

* use spaces

* fix error

* use spaces

* fix CI errors

* use altest api version as default for Avocado

* update host to eastus2euap endpoint to check manifest

* MGRP S360 Vuln (Azure#22832)

* Add blockchain to latest profile

* Add additional types

* Fix Swagger issues

* Solve validation

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>

* use old api versionf or operations

* Azure Orbital - swagger fix for api-version 2022-11-01 (Azure#23441)

* added example for the new field

* updated the double ref that was causing build failure

* Fixed PrometheusRuleGroups examples (Azure#23390)

* Fixed PrometheusRuleGroups examples

* One more fix

* Remvoe flattern (Azure#23460)

Co-authored-by: Will Huang <huangwill@microsoft.com>

* Mvad update (Azure#23434)

* Add default value 10 for topContributorCount

* Update AnomalyDetector typespec to latest typespec and Azure.Core versions and fix all warnings

* Update TypeSpec config

* Add back language emitter options

* Fix cspell and model validation errors

---------

Co-authored-by: Chunlei Wang <chuwan@microsoft.com>

* revert Operations example api version

* add codeowners for Compute Instance swagger (Azure#23437)

Co-authored-by: Naman Agarwal <naagarw@microsoft.com>

* [Hub Generated] Review request for Microsoft.DevHub to add version preview/2022-10-11-preview (Azure#22828)

* Adds base for updating Microsoft.DevHub from version preview/2022-04-01-preview to version 2022-10-11-preview

* Updates readme

* Updates API version in new specs and examples

* start 10-11 preview

* add words

* fix readme version

* update swagger version

* add second putworkflow example

* fix generatepreviewartifactsresponse

* align generate preview artifacts example

* update param locations that got changed

* add x-ms-client-flatten for artifact properties

* Adding WorkflowRunStatus

* Fixing enum name

* add namespace to example

---------

Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>

* Update readme.python.md (Azure#23208)

* fixing async response type for machinelearningservices-2023-02-01-preview (Azure#23105)

* fixing regex pattern and async response type

* remove update to regex

* Fix lint error for Datadog RP (Azure#23477)

* Fix link error for Datadog RP

* Fix version

* merging billing fix to public repo (Azure#23424)

Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>

* use management.auzre.com endpoint

* fix package version in readme

---------

Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
Co-authored-by: will <koyasu221b@gmail.com>
Co-authored-by: Will Huang <huangwill@microsoft.com>
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
Co-authored-by: Naman Agarwal <namanag16@gmail.com>
Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
Co-authored-by: David Gamero <david340804@gmail.com>
Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
Co-authored-by: Gaurav <bang.gourav@gmail.com>
Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>

* fix tag in readme

* update example with capabilities example

* fix typo

---------

Co-authored-by: ramoka178 <57157576+ramoka178@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Stuti Kumar <113545470+stuti-1807@users.noreply.github.com>
Co-authored-by: giladsu <43436811+giladsu@users.noreply.github.com>
Co-authored-by: will <koyasu221b@gmail.com>
Co-authored-by: Will Huang <huangwill@microsoft.com>
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
Co-authored-by: Naman Agarwal <namanag16@gmail.com>
Co-authored-by: Naman Agarwal <naagarw@microsoft.com>
Co-authored-by: David Gamero <david340804@gmail.com>
Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Karishma Daga <karishmadaga@microsoft.com>
Co-authored-by: vikotha <81368129+vikotha@users.noreply.github.com>
Co-authored-by: Gaurav <bang.gourav@gmail.com>
Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
@akania
Copy link
Member

akania commented Aug 16, 2024

closing as it's a stale issue, please reopen if issue still persists

@akania akania closed this as completed Aug 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Communication - Calling Server Communication - Identity customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

6 participants