-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Language Text] Add support for v2022-10-01-preview #23208
Merged
deyaaeldeen
merged 7 commits into
Azure:feature/ai-language-text@1.1
from
deyaaeldeen:language-text-ignite
Sep 16, 2022
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
52b832c
[Language Text] Add support for Ignite features
deyaaeldeen 3d71382
address feedback
deyaaeldeen 86aa77e
fix dep version
deyaaeldeen 424334f
merge upstream/main
deyaaeldeen 538c4c6
add support for entity resolution and address feedback
deyaaeldeen 2ea10ea
address feedback
deyaaeldeen 1857259
fix
deyaaeldeen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given how long this list is, if we're going to keep putting every feature our SDK supports in the README, we should probably start making these links to bookmarks. GitHub does generate a TOC, but it's hidden and, in my experience, not a lot of people know about it. Besides, some of these READMEs get rendered in package repo sites across different languages. Bookmarks should still work there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @kristapratico @joseharriaga @mayurid @mssfang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By "links to bookmarks" do you mean linked to the service docs pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, e.g.,
Headings are automatically transformed into slugs, though with words like "a", "an", "the", etc., some renderers remove them. If that's a concern, be explicit:
## A Link Bookmark<a name="link-bookmark"></a>
My worry is that with so many features - and always more - with code snippets, the README is getting so large it's harder to navigate and quite overwhelming without either breaking it up, or at least making it easier to jump to interesting sections for the reader.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah agreed, we got this feedback awhile back: Azure/azure-sdk-for-python#19435 (from Johan IIRC). In Python, we haven't been adding a Readme example with every new feature, instead we link out specifically to the sample. edit -- under the Examples section, though, not under the first header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points, I guess the main question here is how to present all the features on an equal footing and still be short and sweet. How does everyone feel about Python's?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened #23242 to track this.