-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking change detector] doesn't work well for multiapi package of Mgmt SDK #36755
Comments
@msyyc I looked into this and the code report is reporting on all modules....however not incrementally as you mentioned that the old tool did. How was the "merge" performed in the old tool? Was the latest version merged on top of the last version released (preview or stable)? Or do we need to merge all module versions? And is there any value in that? Seems like merging with the last version should be enough to get the changes listed. |
Could we compare the data from latest version against the last date-based version? So for the eventhub example you shared above, could we extract the api for version v2022_10_01_preview (we could merge the last stable version here as well to be safe) with the contents of v2024_01_01? |
old tool will generate report for each api-versin subfolder then merge these reports. The merge logic is that sort the subfolder then update them one by one. So the latest api-version wins while some types that only exists in older api-version are still kept.
|
Got it, I'll work on a way to do this in the new tool. Thanks for the info |
For multiapi package of Mgmt SDK, current breaking change detector doesn't work well. For example:
(1) azure-mgmt-eventhub of PR #36724
chagnelog from detector
changelog from old tool
(2) azure-mgmt-compute of #36725
changelog from dector is empty
changelog from old tool
FYI: old changelog tool will generate code report for each api-version, then merge these code report into one, then generate changelog.
The text was updated successfully, but these errors were encountered: