Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bct] Support versioned modules #37100

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Conversation

catalinaperalta
Copy link
Member

@catalinaperalta catalinaperalta commented Aug 30, 2024

Support the old versioned module design by merging the code reports similarly to how the old tool did it.

Fixes #36755

@catalinaperalta catalinaperalta requested a review from msyyc August 30, 2024 00:43
@catalinaperalta
Copy link
Member Author

@msyyc I tested this out on the eventhub changes and we're outputting very similar change reports as the old tool now:
image

@catalinaperalta catalinaperalta marked this pull request as ready for review August 30, 2024 00:47
@catalinaperalta catalinaperalta requested a review from msyyc August 30, 2024 23:07
Copy link
Member

@msyyc msyyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test it locally and it works as expected. Thanks for your work!

@catalinaperalta
Copy link
Member Author

/check-enforcer evaluate

@catalinaperalta catalinaperalta merged commit edf1164 into main Sep 3, 2024
6 checks passed
@catalinaperalta catalinaperalta deleted the bc/versioned-module-report branch September 3, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[breaking change detector] doesn't work well for multiapi package of Mgmt SDK
3 participants