Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultAzureCredential supports public cloud only #8148

Closed
chlowell opened this issue Oct 23, 2019 · 0 comments · Fixed by #8154
Closed

DefaultAzureCredential supports public cloud only #8148

chlowell opened this issue Oct 23, 2019 · 0 comments · Fixed by #8154
Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.

Comments

@chlowell
Copy link
Member

The default credential is currently a chain of EnvironmentCredential, ManagedIdentityCredential, and (on Windows) SharedTokenCacheCredential.

These credentials unevenly support multiple clouds:

  • EnvironmentCredential accepts an authority kwarg but this is undocumented because the credential is intended to be configured entirely by environment variables. Selecting cloud via environment variable requires a cross-language design and implementation in azure-core (Azure.Core & Azure.Identity needs to be updated to support env vars #8094).
  • cloud selection is meaningless for ManagedIdentityCredential (and any fix must consider that)
  • SharedTokenCredential accepts an authority kwarg (for identity, this is what changes between clouds)

I think the best solution has two parts:

  • azure-core implements cloud selection by environment variable
  • DefaultAzureCredential accepts an authority kwarg, and passes it only to credentials expecting it. We can pass it to EnvironmentCredential as a workaround pending azure-core changes.
@chlowell chlowell added Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. labels Oct 23, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant