Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable authority for DefaultAzureCredential #8154

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Configurable authority for DefaultAzureCredential #8154

merged 2 commits into from
Oct 24, 2019

Conversation

chlowell
Copy link
Member

Fixes #8148

@chlowell chlowell requested a review from schaabs as a code owner October 23, 2019 19:49
@chlowell chlowell self-assigned this Oct 23, 2019
@adxsdk6
Copy link

adxsdk6 commented Oct 23, 2019

Can one of the admins verify this patch?

@chlowell chlowell added Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. labels Oct 23, 2019
KieranBrantnerMagee
KieranBrantnerMagee approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@KieranBrantnerMagee KieranBrantnerMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chlowell chlowell requested a review from johanste October 23, 2019 23:15
@chlowell chlowell merged commit 1ab9f19 into Azure:master Oct 24, 2019
@chlowell chlowell deleted the default-authority branch October 24, 2019 00:48
fengzhou-msft pushed a commit that referenced this pull request Nov 5, 2019
@chlowell @fengzhou-msft
Configurable authority for DefaultAzureCredential (#8154)
6e89f3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KieranBrantnerMagee KieranBrantnerMagee KieranBrantnerMagee approved these changes

@johanste johanste johanste approved these changes

@schaabs schaabs Awaiting requested review from schaabs

Assignees

@chlowell chlowell

Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DefaultAzureCredential supports public cloud only
4 participants
@chlowell @adxsdk6 @johanste @KieranBrantnerMagee