Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blob versioning #11154

Merged
merged 5 commits into from
Jun 10, 2020
Merged

Blob versioning #11154

merged 5 commits into from
Jun 10, 2020

Conversation

xiafu-msft
Copy link
Contributor

No description provided.

@xiafu-msft xiafu-msft changed the base branch from master to feature/storage-stg73 April 30, 2020 17:58
@xiafu-msft xiafu-msft force-pushed the feature/storage-stg73 branch from c8b24fe to 8f45e1a Compare May 2, 2020 00:47
@xiafu-msft xiafu-msft force-pushed the feature/storage-stg73 branch from 8f45e1a to d08d639 Compare May 12, 2020 21:16
@xiafu-msft xiafu-msft marked this pull request as ready for review May 14, 2020 00:23
annatisch
annatisch requested changes May 14, 2020
View reviewed changes
sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py Outdated Show resolved Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py Outdated
:keyword str version_id:
The version id parameter is an opaque DateTime
value that, when present, specifies the version of the blob to delete.
It for service version 2019-10-10 and newer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Introduced in service version 2019-10-10"
Also add the docstring tag for new parameters in the SDK.

sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py Outdated
@@ -637,6 +640,7 @@ def _delete_blob_options(self, delete_snapshots=False, **kwargs):
raise ValueError("The delete_snapshots option cannot be used with a specific snapshot.")
options = self._generic_delete_blob_options(delete_snapshots, **kwargs)
options['snapshot'] = self.snapshot
options['version_id'] = kwargs.pop('version_id', None) or self.version_id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're also supporting version override for download and delete we should add to the docstring :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I missed the docstr.
How do you feel about this kwargs.pop('version_id', None) or self.version_id, do you feel redundant or it's fine?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed offline, remove self.version_id

sdk/storage/azure-storage-blob/azure/storage/blob/_models.py Outdated
@@ -994,19 +998,23 @@ class BlobSasPermissions(object):
destination of a copy operation within the same account.
:param bool delete:
Delete the blob.
:param bool delete_version:
Delete the blob version for the versioning enabled storage account.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused by this.... does it mean we are giving permission to delete non-current blob versions? Or any blob in a version-enabled-account?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's to give permission to delete the non-current(past) versions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I think we should rename this... maybe delete_previous_versions or something...

sdk/storage/azure-storage-blob/azure/storage/blob/_shared/models.py Outdated Show resolved Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_shared_access_signature.py Outdated Show resolved Hide resolved
@annatisch annatisch added APIChange This PR contains an addition or change to the API signature and must be reviewed by an architect. Storage Storage Service (Queues, Blobs, Files) labels May 15, 2020
@xiafu-msft xiafu-msft merged commit c8fa69e into Azure:feature/storage-stg73 Jun 10, 2020
xiafu-msft added a commit that referenced this pull request Jun 10, 2020
@xiafu-msft
Blob versioning (#11154)
73066a2
xiafu-msft added a commit that referenced this pull request Jul 7, 2020
@xiafu-msft @kasobol-msft
@zezha-msft @annatisch
Feature/storage stg73 (#12272)
900aa7d 
* [Storage]STG73

* [Blob][Swagger]Update Swagger (#10943)

* [Blob][Swagger]Regenerate Swagger Code

* fix container test failure caused by list_containers include type change

* [Storage] Internal avro parser. (#10764)

* initial avro parser

* try fixing test...

* falling in love with python compatibility...

* make linter happy.

* raise StopIteration when there is no more bytes instead of tracking file length.

* async avro parser

* fix syntax for Python 3.5

* get rid of 'readers_schema' as we only honor schema that has been written to file ('writer_schema').

* pr feedback

* trim unused code.

* pr feedback.

* simplify skip sync in next.

* move avro tests from _shared.

* Jumbo blob support (#11176)

* wip

* initial test coverage.

* wip.

* wip

* single upload.

* add async tests.

* disable 50k block tests.

* datalake append.

* async datalake

* disable tests that send large payload over network.

* pr feedback.

* Undelete share (#11394)

* Undelete container (#11339)

* [Storage][Blob] Added support for Object Replication (#11525)

* Blob versioning (#11154)

* [Blob][QuickQuery]Add Quick Query Support (#10946)

* [Blob][STG73]Blob Tags (#11418)

* regenerate code (#11964)

* fix the bug which caused only showing fatal error (#11997)

* [Storage][STG73]Address API Review Comments (#12111)

* [Storage][STG73]Address API Review Comments

* [Storage][STG73]dict<policy, rules> -> list(ObjectReplicationPolicy)

* fix blob tag_value test

* expose ObjectReplicationPolicy and ObjectReplicationRule, fix test

* fix test

* Changefeed (#10755)

* [ChangeFeed]Add ChangeFeed Package

* test_avro failure

* update dev_requirement.txt

* change namespace to azure.storage.blob.changefeed

* address comments

* optimize memory when reading changefeed events

* namespace change

* set up package change

* fix failed tests

* readme and kwargs

* Update sdk/storage/azure-storage-blob-changefeed/azure/storage/blob/changefeed/_change_feed_client.py

Co-authored-by: Rakshith Bhyravabhotla <sabhyrav@microsoft.com>

* address comments

* 'azure-storage-blob>=12.3.0' which does not match the frozen requirement 'azure-storage-blob~=1.3'

Co-authored-by: Rakshith Bhyravabhotla <sabhyrav@microsoft.com>

* [Storage-Blob] Quick Query API (#11991)

* Renamed query error

* Renamed query reader

* Updated config models

* Updated format request params

* Updated iterator

* fix the bug which caused only showing fatal error

* Updated Error message

* Fixed query helper

* Started test conversion

* small fix

* Fixed tests

* Updated error handling + json model

* Updated recordings

* Removed old recording

* Added iter tests

* Iter test recordings

* Fix test

* Remove extra recording

* Fix pylint

* Some docs cleanup

* Renamed iter_records -> iter_stream

* Review feedback

* Updated tests

* Missing commas

* Fix syntax

* Fix pylint

Co-authored-by: xiafu <xiafu@microsoft.com>

* tag sas (#12258)

* tag sas

* disable undelete_container

* pylint

* skip undelete_container tests

* [Blob][Versioning]Disable Versioning Live Test (#12281)

* [Blob][QQ]Default output_format to input_format (#12283)

* [Storage][Jumbo]Remove super (#12314)

* [Storage][JumboBlob]remove empty super()

* pypy3

* change sas version to latest

* set tags account location to central canada

* re-recording queue

* changefeed paths generator

* mark tests for vid as playback only

* fix changefeed

* fix pylint
make the test account location for tags to central canada

* add a delay before calling find_blobs_by_tags

* remove tags header

* mark a large file test playback only

* revert "mark a large file test playback only"
skip upload large file test
address comment

* move tag permission and filter_by_tags permission to kwargs

Co-authored-by: Kamil Sobol <61715331+kasobol-msft@users.noreply.github.com>
Co-authored-by: Ze Qian Zhang <zezha@microsoft.com>
Co-authored-by: Rakshith Bhyravabhotla <sabhyrav@microsoft.com>
Co-authored-by: annatisch <antisch@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annatisch annatisch annatisch requested changes

@amishra-dev amishra-dev Awaiting requested review from amishra-dev

@rakshith91 rakshith91 Awaiting requested review from rakshith91

@zezha-msft zezha-msft Awaiting requested review from zezha-msft

Assignees
No one assigned
Labels
APIChange This PR contains an addition or change to the API signature and must be reviewed by an architect. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiafu-msft @annatisch