Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Renames / Regen #11342

Merged
merged 21 commits into from
May 19, 2020
Merged

Search Renames / Regen #11342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
4112ee6
add regenerated swagger
bryevdv May 7, 2020
e01d6ba
Analyzer -> LexicalAnalyzer
bryevdv May 7, 2020
742a3c5
StandardAnalyzer -> LuceneStandardAnalyzer
bryevdv May 7, 2020
299f7b0
StandardTokenizer -> LuceneStandardTokenizer
bryevdv May 7, 2020
0f823cd
DataSource -> SearchIndexerDataSource
bryevdv May 7, 2020
748e517
DataContainer -> SearchIndexerDataContainer
bryevdv May 7, 2020
520fb79
Skillset -> SearchIndexerSkillset
bryevdv May 7, 2020
ed51f76
Skill -> SearchIndexerSkill
bryevdv May 7, 2020
61e36fd
TokenInfo -> AnalyzedTokenInfo
bryevdv May 7, 2020
2523747
EncryptionKey -> SearchResourceEncryptionKey
bryevdv May 7, 2020
e5854d7
IndexerExecutionInfo -> SearchIndexerStatus
bryevdv May 7, 2020
8720cb7
Indexer -> SearchIndexer
bryevdv May 7, 2020
dded0d9
Tokenizer -> LexicalTokenizer
bryevdv May 7, 2020
9dafa5e
Field -> SearchField
bryevdv May 8, 2020
80b84f1
Index -> SearchIndex
bryevdv May 8, 2020
9dfc8e6
update for AccessCondition
bryevdv May 8, 2020
5e4e27e
update tests
bryevdv May 8, 2020
6375e26
regenerate w/o x-ms-pageable
bryevdv May 8, 2020
5afc309
Merge branch 'master' into bryanv/update_swagger
bryevdv May 19, 2020
ee34d27
remove conflict merge junk
bryevdv May 19, 2020
bb848e1
pylint
bryevdv May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 27 additions & 27 deletions sdk/search/azure-search-documents/azure/search/documents/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@
edm,
)
from ._service._generated.models import (
Analyzer,
AnalyzeRequest,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to tell from the diff, but these *Request and *Result classes aren't actually exported, are they? They should most often (always, IIRC) be wrapped/transformed before returning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for DataSourceCredentials I see below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they have been used directly since awhile ago: https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/search/azure-search-documents/samples/sample_analyze_text.py

AnalyzeResult,
AnalyzedTokenInfo,
AsciiFoldingTokenFilter,
AzureActiveDirectoryApplicationCredentials,
CharFilter,
Expand All @@ -55,24 +55,18 @@
ConditionalSkill,
CorsOptions,
CustomAnalyzer,
DataSource,
DataSourceCredentials,
DataContainer,
DictionaryDecompounderTokenFilter,
DistanceScoringFunction,
DistanceScoringParameters,
EdgeNGramTokenFilter,
EdgeNGramTokenizer,
ElisionTokenFilter,
EncryptionKey,
EntityRecognitionSkill,
Field,
FreshnessScoringFunction,
FreshnessScoringParameters,
GetIndexStatisticsResult,
ImageAnalysisSkill,
Index,
Indexer,
IndexingSchedule,
IndexingParameters,
InputFieldMappingEntry,
Expand All @@ -82,7 +76,11 @@
KeywordTokenizer,
LanguageDetectionSkill,
LengthTokenFilter,
LexicalAnalyzer,
LexicalTokenizer,
LimitTokenFilter,
LuceneStandardAnalyzer,
LuceneStandardTokenizer,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should also be a (new) LuceneStandardTokenizerV2 that was added a couple weeks ago.

MagnitudeScoringFunction,
MagnitudeScoringParameters,
MappingCharFilter,
Expand All @@ -98,16 +96,20 @@
PatternReplaceTokenFilter,
PhoneticTokenFilter,
RegexFlags,
SearchField,
SearchIndex,
SearchIndexer,
SearchIndexerDataContainer,
SearchIndexerDataSource,
SearchIndexerSkillset,
SearchResourceEncryptionKey,
ScoringFunction,
ScoringProfile,
SentimentSkill,
ShaperSkill,
ShingleTokenFilter,
Skillset,
SnowballTokenFilter,
SplitSkill,
StandardAnalyzer,
StandardTokenizer,
StemmerOverrideTokenFilter,
StemmerTokenFilter,
StopAnalyzer,
Expand All @@ -120,8 +122,6 @@
TextTranslationSkill,
TextWeights,
TokenFilter,
TokenInfo,
Tokenizer,
TruncateTokenFilter,
UaxUrlEmailTokenizer,
UniqueTokenFilter,
Expand All @@ -142,7 +142,7 @@
__all__ = (
"AnalyzeRequest",
"AnalyzeResult",
"Analyzer",
"AnalyzedTokenInfo",
"AsciiFoldingTokenFilter",
"AutocompleteQuery",
"AzureActiveDirectoryApplicationCredentials",
Expand All @@ -154,24 +154,18 @@
"ConditionalSkill",
"CorsOptions",
"CustomAnalyzer",
"DataSource",
"DataSourceCredentials",
"DataContainer",
"DictionaryDecompounderTokenFilter",
"DistanceScoringFunction",
"DistanceScoringParameters",
"EdgeNGramTokenFilter",
"EdgeNGramTokenizer",
"ElisionTokenFilter",
"EncryptionKey",
"EntityRecognitionSkill",
"Field",
"FreshnessScoringFunction",
"FreshnessScoringParameters",
"GetIndexStatisticsResult",
"ImageAnalysisSkill",
"Index",
"Indexer",
"IndexingSchedule",
"IndexingParameters",
"IndexAction",
Expand All @@ -184,7 +178,11 @@
"KeywordTokenizer",
"LanguageDetectionSkill",
"LengthTokenFilter",
"LexicalAnalyzer",
"LexicalTokenizer",
"LimitTokenFilter",
"LuceneStandardAnalyzer",
"LuceneStandardTokenizer",
"MagnitudeScoringFunction",
"MagnitudeScoringParameters",
"MappingCharFilter",
Expand All @@ -204,25 +202,29 @@
"RegexFlags",
"ScoringFunction",
"ScoringProfile",
"SearchClient",
"SearchDataSourcesClient",
"SearchClient",
"SearchField",
"SearchIndex",
"SearchIndexer",
"SearchIndexerDataContainer",
"SearchIndexerDataSource",
"SearchIndexerSkillset",
"SearchIndexersClient",
"SearchIndexesClient",
"SearchSkillsetsClient",
"SearchSynonymMapsClient",
"SearchItemPaged",
"SearchQuery",
"SearchResourceEncryptionKey",
"SearchServiceClient",
"SearchSkillsetsClient",
"SearchSynonymMapsClient",
"SearchableField",
"SentimentSkill",
"ShaperSkill",
"ShingleTokenFilter",
"SimpleField",
"Skillset",
"SnowballTokenFilter",
"SplitSkill",
"StandardAnalyzer",
"StandardTokenizer",
"StemmerOverrideTokenFilter",
"StemmerTokenFilter",
"StopAnalyzer",
Expand All @@ -236,8 +238,6 @@
"TextTranslationSkill",
"TextWeights",
"TokenFilter",
"TokenInfo",
"Tokenizer",
"TruncateTokenFilter",
"UaxUrlEmailTokenizer",
"UniqueTokenFilter",
Expand Down
2 changes: 1 addition & 1 deletion sdk/search/azure-search-documents/azure/search/documents/_index/_generated/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# coding=utf-8
# --------------------------------------------------------------------------
# Code generated by Microsoft (R) AutoRest Code Generator (autorest: 3.0.6246, generator: {generator})
# Code generated by Microsoft (R) AutoRest Code Generator (autorest: 3.0.6257, generator: {generator})
# Changes may cause incorrect behavior and will be lost if the code is regenerated.
# --------------------------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion sdk/search/azure-search-documents/azure/search/documents/_index/_generated/_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# coding=utf-8
# --------------------------------------------------------------------------
# Code generated by Microsoft (R) AutoRest Code Generator (autorest: 3.0.6246, generator: {generator})
# Code generated by Microsoft (R) AutoRest Code Generator (autorest: 3.0.6257, generator: {generator})
# Changes may cause incorrect behavior and will be lost if the code is regenerated.
# --------------------------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion ...h/azure-search-documents/azure/search/documents/_index/_generated/_search_index_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# coding=utf-8
# --------------------------------------------------------------------------
# Code generated by Microsoft (R) AutoRest Code Generator (autorest: 3.0.6246, generator: {generator})
# Code generated by Microsoft (R) AutoRest Code Generator (autorest: 3.0.6257, generator: {generator})
# Changes may cause incorrect behavior and will be lost if the code is regenerated.
# --------------------------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion sdk/search/azure-search-documents/azure/search/documents/_index/_generated/aio/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# coding=utf-8
# --------------------------------------------------------------------------
# Code generated by Microsoft (R) AutoRest Code Generator (autorest: 3.0.6246, generator: {generator})
# Code generated by Microsoft (R) AutoRest Code Generator (autorest: 3.0.6257, generator: {generator})
# Changes may cause incorrect behavior and will be lost if the code is regenerated.
# --------------------------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion ...ure-search-documents/azure/search/documents/_index/_generated/aio/_configuration_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# coding=utf-8
# --------------------------------------------------------------------------
# Code generated by Microsoft (R) AutoRest Code Generator (autorest: 3.0.6246, generator: {generator})
# Code generated by Microsoft (R) AutoRest Code Generator (autorest: 3.0.6257, generator: {generator})
# Changes may cause incorrect behavior and will be lost if the code is regenerated.
# --------------------------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion ...arch-documents/azure/search/documents/_index/_generated/aio/_search_index_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# coding=utf-8
# --------------------------------------------------------------------------
# Code generated by Microsoft (R) AutoRest Code Generator (autorest: 3.0.6246, generator: {generator})
# Code generated by Microsoft (R) AutoRest Code Generator (autorest: 3.0.6257, generator: {generator})
# Changes may cause incorrect behavior and will be lost if the code is regenerated.
# --------------------------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion ...earch-documents/azure/search/documents/_index/_generated/aio/operations_async/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# coding=utf-8
# --------------------------------------------------------------------------
# Code generated by Microsoft (R) AutoRest Code Generator (autorest: 3.0.6246, generator: {generator})
# Code generated by Microsoft (R) AutoRest Code Generator (autorest: 3.0.6257, generator: {generator})
# Changes may cause incorrect behavior and will be lost if the code is regenerated.
# --------------------------------------------------------------------------

Expand Down
Loading