Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cleanup failing on 3.8.3 #11607

Merged
merged 1 commit into from
May 22, 2020
Merged

Fix Cleanup failing on 3.8.3 #11607

merged 1 commit into from
May 22, 2020

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented May 22, 2020

For some reason this was working in 3.8.2, but not in 3.8.3. Being __exit__ contract is to get three args anyway, it was working for bad reasons, so fixing it

@lmazuel lmazuel merged commit 39f2757 into master May 22, 2020
@lmazuel lmazuel deleted the fix_cleanup branch May 22, 2020 22:47
iscai-msft added a commit that referenced this pull request May 26, 2020
…into feature/text_analytics_v3.0

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  Release azure mgmt containerregistry (#11460)
  Prepare core 1.6.0 on master (#11610)
  Add force parameter to SwaggerToSdk CLI (#11609)
  LRO continuation_token (#10801)
  Remove unecessary import (#11606)
  Fix Cleanup failing on 3.8.3 (#11607)
  remove DataSourceCredentials (#11605)
  Search synonym map (#11590)
  Fix copy tests (#11594)
  Make use_training_labels positional required (#11529)
  Search refactoring 2 (#11584)
  Search refactoring 1 (#11572)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Jan 12, 2021
[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2019-09-01 (Azure#11607)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Jan 12, 2021
[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2019-09-01 (Azure#11607)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants