code refactoring #11638
Merged
code refactoring #11638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heaths
approved these changes
May 27, 2020
| 'name': {'key': 'name', 'type': 'str'}, | ||
| 'type': {'key': 'type', 'type': 'str'}, | ||
| 'key': {'key': 'key', 'type': 'bool'}, | ||
| 'is_hidden': {'key': 'isHidden', 'type': 'bool'}, |
There was a problem hiding this comment.
Why is this one prefaced with "is" while others are not? I'd be consistent for your language. Also, I'm not clear on what this _attribute_map is, since there's no isHidden on the model itself but, this is to be the reverse of retrievable that is on the model.
There was a problem hiding this comment.
All models exposed to users use is_hidden. Could you tell me which one you found w/o "is". It may be a bug...
There was a problem hiding this comment.
None of the properties below this had it. If these are internal mappings of some sort, not a big deal, but raises the question where is_hidden is coming from, given it's the negation of the JSON field retrievable.
|
/check-enforcer reset |
|
/check-enforcer evaluate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.