Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InteractiveBrowserCredential is unavailable when it can't bind a port #11665

Merged
merged 2 commits into from
May 27, 2020
Merged

InteractiveBrowserCredential is unavailable when it can't bind a port #11665

merged 2 commits into from
May 27, 2020

Conversation

chlowell
Copy link
Member

get_token loops over local ports, trying to start an HTTP server on one of them. The credential should raise CredentialUnavailableError when the server fails to bind a port. However, when that happens redirect_uri is unassigned and one gets a different error when get_token references it after the loop.

@chlowell chlowell added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels May 27, 2020
@chlowell chlowell requested a review from xiangyan99 May 27, 2020 23:37
@chlowell chlowell requested a review from schaabs as a code owner May 27, 2020 23:37
@chlowell chlowell merged commit a230e92 into Azure:master May 27, 2020
@chlowell chlowell deleted the ibc-cannot-bind branch May 27, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangyan99 xiangyan99 xiangyan99 approved these changes

@schaabs schaabs Awaiting requested review from schaabs

Assignees
No one assigned
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chlowell @xiangyan99