Search refactoring 3 #11804
Merged
Search refactoring 3 #11804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heaths
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
Changes look good; however, see my comment in our Teams channel about pushing text back into AnalyzeRequest and renaming that to AnalyzeTextRequest, following recommendations on method -> model names. Turns out, nothing about it is optional, and just text isn't enough.
You could also do that as a separate PR, but I seem to recall you wanting to minimize PRs.
|
/azp run azure-sdk-for-python - update_pr |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xiangyan99
added a commit
that referenced
this pull request
Jun 4, 2020
* [HDInsight] Fix hdi test failure (#11806) * Initial generation Synapse autorest v5 * Fix empty model generation * Fix Test Failure: Skip 3 test case: test_create_with_adlsgen1, test_create_with_additional_storage, test_oms_on_running_cluster Rename test_http_extend to test_gateway_setting for http settings is replaced with gateway settings Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com> Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com> * disable some by design bandit warnings (#11495) * disable some by design bandit warnings * Packaging update of azure-mgmt-datalake-analytics Co-authored-by: Azure SDK Bot <aspysdk2@microsoft.com> * Increment package version after release of azure_core (#11795) * Use subject claim as home_account_id when no client_info (#11639) * Refactor ClientCertificateCredential to use AadClient (#11719) * Refactor ClientSecretCredential to use AadClient (#11718) * [Cosmos] Fixed incorrect ID type error (#11798) * Fixed incorrect ID type error * Fix pylint * [text analytics] Update readme (#11796) * try something (#11797) * Search refactoring 3 (#11804) * create_or_update takes object * rename is_hidden to hidden * fix types * updates Co-authored-by: aim-for-better <zhenyu.zhou@microsoft.com> Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com> Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com> Co-authored-by: Azure SDK Bot <aspysdk2@microsoft.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Charles Lowell <chlowe@microsoft.com> Co-authored-by: annatisch <antisch@microsoft.com> Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com> Co-authored-by: Krista Pratico <krpratic@microsoft.com>
xiangyan99
added a commit
that referenced
this pull request
Jun 5, 2020
* search method only takes search_text * update * Add AzureCliCredential and VSCodeCredential to public API (#11790) (#11805) Co-authored-by: Charles Lowell <chlowe@microsoft.com> * get master (#11823) * [HDInsight] Fix hdi test failure (#11806) * Initial generation Synapse autorest v5 * Fix empty model generation * Fix Test Failure: Skip 3 test case: test_create_with_adlsgen1, test_create_with_additional_storage, test_oms_on_running_cluster Rename test_http_extend to test_gateway_setting for http settings is replaced with gateway settings Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com> Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com> * disable some by design bandit warnings (#11495) * disable some by design bandit warnings * Packaging update of azure-mgmt-datalake-analytics Co-authored-by: Azure SDK Bot <aspysdk2@microsoft.com> * Increment package version after release of azure_core (#11795) * Use subject claim as home_account_id when no client_info (#11639) * Refactor ClientCertificateCredential to use AadClient (#11719) * Refactor ClientSecretCredential to use AadClient (#11718) * [Cosmos] Fixed incorrect ID type error (#11798) * Fixed incorrect ID type error * Fix pylint * [text analytics] Update readme (#11796) * try something (#11797) * Search refactoring 3 (#11804) * create_or_update takes object * rename is_hidden to hidden * fix types * updates Co-authored-by: aim-for-better <zhenyu.zhou@microsoft.com> Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com> Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com> Co-authored-by: Azure SDK Bot <aspysdk2@microsoft.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Charles Lowell <chlowe@microsoft.com> Co-authored-by: annatisch <antisch@microsoft.com> Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com> Co-authored-by: Krista Pratico <krpratic@microsoft.com> * rename AnalyzeText to AnalyzeTextRequest * fixes * update * update changelog * update * add types * update * rename batch methods * update * update * update * updates Co-authored-by: Charles Lowell <chlowe@microsoft.com> Co-authored-by: aim-for-better <zhenyu.zhou@microsoft.com> Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com> Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com> Co-authored-by: Azure SDK Bot <aspysdk2@microsoft.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: annatisch <antisch@microsoft.com> Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com> Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11803