Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

begin_recognize_receipts APIs now return RecognizedForm #11894

Merged
merged 4 commits into from
Jun 11, 2020

Conversation

rakshith91
Copy link
Contributor

@rakshith91 rakshith91 commented Jun 9, 2020

Fixes #11880

@rakshith91 rakshith91 changed the title Initial Commit begin_recognize_receipts and begin_recognize_receipts_from_url now return RecognizedForm and begin_recognize_receipts APIs now return RecognizedReceipt. Jun 9, 2020
@rakshith91 rakshith91 changed the title begin_recognize_receipts and begin_recognize_receipts_from_url now return RecognizedForm and begin_recognize_receipts APIs now return RecognizedReceipt. begin_recognize_receipts and begin_recognize_receipts_from_url now return RecognizedForm Jun 9, 2020
@rakshith91 rakshith91 changed the title begin_recognize_receipts and begin_recognize_receipts_from_url now return RecognizedForm begin_recognize_receipts APIs now return RecognizedForm Jun 9, 2020
@rakshith91 rakshith91 marked this pull request as ready for review June 9, 2020 02:58
@@ -1,5 +1,12 @@
# Change Log azure-ai-formrecognizer

## 1.0.0b4 (Unreleased)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, you just forgot to remove mention of RecognizedReceipt from the readme: https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/formrecognizer/azure-ai-formrecognizer#formrecognizerclient

@@ -123,7 +123,6 @@ See the full details regarding [authentication][cognitive_authentication] of cog

- Recognizing form fields and content using custom models trained to recognize your custom forms. These values are returned in a collection of `RecognizedForm` objects.
- Recognizing form content, including tables, lines and words, without the need to train a model. Form content is returned in a collection of `FormPage` objects.
- Recognizing common fields from US receipts, using a pre-trained receipt model on the Form Recognizer service. These fields and meta-data are returned in a collection of `RecognizedReceipt` objects.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still include this sentence, just say that it returns a collection of RecognizedForm

@kristapratico
Copy link
Member

LGTM, I'll approve after we release

kristapratico
kristapratico previously approved these changes Jun 10, 2020
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebasing on master should fix the analyze step error in CI

@rakshith91 rakshith91 merged commit be2e10a into Azure:master Jun 11, 2020
@rakshith91 rakshith91 deleted the recognize_receipt branch June 11, 2020 19:51
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[formrecognizer] Remove RecognizedReceipt, return RecognizedForm
3 participants