Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typing fix #11985

Merged
merged 3 commits into from
Jun 11, 2020
Merged

typing fix #11985

merged 3 commits into from
Jun 11, 2020

Conversation

xiangyan99
Copy link
Member

No description provided.

@xiangyan99
Copy link
Member Author

/azp run python - core

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xiangyan99
Copy link
Member Author

/azp run python - core

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xiangyan99
Copy link
Member Author

/azp run python - core

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xiangyan99 xiangyan99 marked this pull request as ready for review June 11, 2020 16:44
@xiangyan99 xiangyan99 requested a review from lmazuel as a code owner June 11, 2020 16:44
@xiangyan99 xiangyan99 requested a review from scbedd June 11, 2020 16:45
scbedd
scbedd approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This is my attempt

But i still don't know why it randomly started.

@xiangyan99 xiangyan99 merged commit b9cc2b9 into master Jun 11, 2020
@xiangyan99 xiangyan99 deleted the core_typing branch June 11, 2020 17:07
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jun 11, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
0784d0b 
…into have_azure_key_credential_policy_take_kwargs

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  typing fix (Azure#11985)
  remove test code that works around service bug (fixed) (Azure#11961)
  Refactor SharedTokenCacheCredential exception handling (Azure#11962)
  add the previous versions of azure-servicebus to the regression exclusion list (Azure#11957)
  Increment package version after release of azure_ai_formrecognizer (Azure#11954)
  Remove redundant await_prepared_test (Azure#11930)
  update changelog date (Azure#11934)
  Sync eng/common directory with azure-sdk-tools repository (Azure#11925)
  [formrecognizer] update recordings, add delay, switch to westcentralus region (Azure#11916)
  Increment package version after release of azure_identity (Azure#11931)
  Resolve Breaking Aggregate Reports (Azure#11825)
  Increment package version after release of azure_ai_textanalytics (Azure#11928)
  update error msg if not supported (Azure#11915)
changlong-liu pushed a commit to changlong-liu/azure-sdk-for-python that referenced this pull request Jul 13, 2020
@xiangyan99 @changlong-liu
typing fix (Azure#11985)
48b7812 
* typing fix
changlong-liu added a commit that referenced this pull request Jul 15, 2020
@changlong-liu @chidozieononiwu @xiangyan99
clean up resources / fix changelog (#12432) (#12459)
bdfb3a2 
* clean up resources / fix changelog (#12432)

* typing fix (#11985)

* typing fix

Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com>
Co-authored-by: Xiang Yan <xiangsjtu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scbedd scbedd scbedd approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiangyan99 @scbedd