Don't redact Key Vault header values in logs #12077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
added
KeyVault
Client
iscai-msft
approved these changes
Jun 22, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jun 23, 2020
…into regenerate_certs * 'master' of https://github.com/Azure/azure-sdk-for-python: Resolve Pip Related Errors (Azure#12157) [Service Bus] Delete swagger file (Azure#12097) Add set_delete_after_tag as a parameter on ResourceGroupPreparer (Azure#11749) Custom Vision Training: release_3_3 Prediction: release_3_1 (Azure#12105) Don't redact Key Vault header values in logs (Azure#12077)
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jun 23, 2020
…into regenerate_keys * 'master' of https://github.com/Azure/azure-sdk-for-python: Resolve Pip Related Errors (Azure#12157) [Service Bus] Delete swagger file (Azure#12097) Add set_delete_after_tag as a parameter on ResourceGroupPreparer (Azure#11749) Custom Vision Training: release_3_3 Prediction: release_3_1 (Azure#12105) Don't redact Key Vault header values in logs (Azure#12077)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Dec 16, 2020
Azure Purview Public Preview API (Azure#12077)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Vault has a couple custom headers whose values we've been unwittingly redacting from logs. This configures
HttpLoggingPolicyto log their values.