Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[formrecognizer] enable logging for live tests #12110

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

kristapratico
Copy link
Member

@kristapratico kristapratico commented Jun 18, 2020

We're seeing live test failures in canary and it would be helpful to have request id's etc to pass on to the service team. The environment variable is set as a devop variable.

@kristapratico kristapratico added Cognitive Services Client This issue points to a problem in the data-plane of the library. FormRecognizer labels Jun 18, 2020
@kristapratico kristapratico self-assigned this Jun 18, 2020
@kristapratico kristapratico marked this pull request as ready for review June 18, 2020 02:26
@kristapratico kristapratico requested a review from rakshith91 June 18, 2020 02:26
Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great @kristapratico . Have you given any thought to moving the code to devtools_testutils?

@kristapratico kristapratico merged commit 9dc54e9 into Azure:master Jun 18, 2020
@kristapratico kristapratico deleted the enablelogging branch June 18, 2020 15:29
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jun 22, 2020
…into regenerate_certs

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  [text analytics] remove duplicate platform info in user agent (Azure#12123)
  [form recognizer] remove duplicate platform info in user agent (Azure#12124)
  fix broken links (Azure#12100)
  Document "<unchanged>" for DataSourceCredentials.connectionString if it is empty (Azure#12129)
  Let the transport handles bad urls (Azure#12106)
  Remove Unneeded Reference to repository resource (Azure#11929)
  enable logging for tests (Azure#12110)
  fix network in batch testcase (Azure#12114)
  update test recording for appservice (Azure#12116)
  Add test for connection monitor and fix test api version. (Azure#12113)
  Minor root readme and mgmt quickstart update for Track 2 mgmt sdk (Azure#12112)
  Quickstart for Track 2 preview management libraries and update root readme for track 2 (Azure#11384)
  Seg fault fix (Azure#11933)
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jun 22, 2020
…into regenerate_keys

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  [text analytics] remove duplicate platform info in user agent (Azure#12123)
  [form recognizer] remove duplicate platform info in user agent (Azure#12124)
  fix broken links (Azure#12100)
  Document "<unchanged>" for DataSourceCredentials.connectionString if it is empty (Azure#12129)
  Let the transport handles bad urls (Azure#12106)
  Remove Unneeded Reference to repository resource (Azure#11929)
  enable logging for tests (Azure#12110)
  fix network in batch testcase (Azure#12114)
  update test recording for appservice (Azure#12116)
  Add test for connection monitor and fix test api version. (Azure#12113)
  Minor root readme and mgmt quickstart update for Track 2 mgmt sdk (Azure#12112)
  Quickstart for Track 2 preview management libraries and update root readme for track 2 (Azure#11384)
  Seg fault fix (Azure#11933)
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jun 22, 2020
…into regenerate_secrets

* 'master' of https://github.com/Azure/azure-sdk-for-python: (39 commits)
  [text analytics] remove duplicate platform info in user agent (Azure#12123)
  [form recognizer] remove duplicate platform info in user agent (Azure#12124)
  fix broken links (Azure#12100)
  Document "<unchanged>" for DataSourceCredentials.connectionString if it is empty (Azure#12129)
  Let the transport handles bad urls (Azure#12106)
  Remove Unneeded Reference to repository resource (Azure#11929)
  enable logging for tests (Azure#12110)
  fix network in batch testcase (Azure#12114)
  update test recording for appservice (Azure#12116)
  Add test for connection monitor and fix test api version. (Azure#12113)
  Minor root readme and mgmt quickstart update for Track 2 mgmt sdk (Azure#12112)
  Quickstart for Track 2 preview management libraries and update root readme for track 2 (Azure#11384)
  Seg fault fix (Azure#11933)
  [formrecognizer] update formrecognizer links to new aka.ms naming (Azure#12079)
  changes in samples tests (Azure#12090)
  readme & sample updates (Azure#12095)
  Update Key Vault minimum azure-core to 1.4.0 (Azure#12074)
  [formrecognizer] test parity with other languages (Azure#12059)
  syncing missing changelog items (Azure#12089)
  updating doc references (Azure#12086)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer Cognitive Services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants