Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Key Vault API versions for sovereign clouds in smoke tests #13130

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

chlowell
Copy link
Member

Smoke tests are failing in sovereign clouds because those clouds don't support Key Vault clients' default API version. Lacking a clean way to discover the supported version at runtime, this PR hardcodes known good versions.

The tests will continue to fail until #13129 merges.

@chlowell chlowell added KeyVault test-reliability Issue that causes tests to be unreliable labels Aug 14, 2020
@chlowell chlowell requested a review from danieljurek August 14, 2020 23:14
@chlowell chlowell force-pushed the fix-key-vault-smoketest branch from 175e4b3 to e9e3d3b Compare August 18, 2020 16:20
Copy link
Contributor

@rakshith91 rakshith91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chlowell
Copy link
Member Author

/check-enforcer evaluate

@chlowell
Copy link
Member Author

/check-enforcer override

@chlowell chlowell merged commit 8fdc73d into Azure:master Aug 18, 2020
@chlowell chlowell deleted the fix-key-vault-smoketest branch August 18, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
KeyVault test-reliability Issue that causes tests to be unreliable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants