Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing #13821

Merged
merged 12 commits into from
Sep 23, 2020
Merged

Update testing #13821

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e75c30b
changes for test_table.py
seankane-msft Sep 10, 2020
9c373e9
fixed up testing, noting which tests do not pass and the reasoning
seankane-msft Sep 10, 2020
b2ba63b
small additions to testing
seankane-msft Sep 10, 2020
cc2e5d6
updated unicode test for storage
seankane-msft Sep 16, 2020
eb78103
final update
seankane-msft Sep 16, 2020
b0d7e3d
merge conflicts
seankane-msft Sep 16, 2020
85006a3
updates that fix user_agent tests
seankane-msft Sep 16, 2020
efbe2ed
test CI returns a longer user agent so flipping the order for this te…
seankane-msft Sep 18, 2020
30b42f3
addresses anna's comments
seankane-msft Sep 21, 2020
8667319
re-recorded a test with a recording error
seankane-msft Sep 21, 2020
e441d45
removed list comprehension for python3.5 compatability
seankane-msft Sep 21, 2020
d7426dd
fixing a testing bug
seankane-msft Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/tables/azure-data-tables/azure/data/tables/_table_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def get_table_access_policy(
**kwargs)
except HttpResponseError as error:
_process_table_error(error)
return {s.id: s.access_policy or AccessPolicy() for s in identifiers} # pylint: disable=E1125
return {s.id: s.access_policy or AccessPolicy(start=None, expiry=None, permission=None) for s in identifiers}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference here? Is this because some of these parameters are required in the constructor?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seem to recall that setting these values to None might actually change the structure of the request body....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes these are required parameters. There are actually two different AccessPolicy classes right now, one in the generated code and another here. The latter inherits from the generated code and all arguments are defaulted to None.


@distributed_trace
def set_table_access_policy(
Expand Down
4 changes: 2 additions & 2 deletions sdk/tables/azure-data-tables/azure/data/tables/aio/_table_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def __init__(
self,
account_url, # type: str
table_name, # type: str
credential, # type : Optional[Any]=None
credential=None, # type : Optional[Any]=None
**kwargs # type: Any
):
# type: (...) -> None
Expand Down Expand Up @@ -163,7 +163,7 @@ async def get_table_access_policy(
**kwargs)
except HttpResponseError as error:
_process_table_error(error)
return {s.id: s.access_policy or AccessPolicy() for s in identifiers}
return {s.id: s.access_policy or AccessPolicy(start=None, expiry=None, permission=None) for s in identifiers}

@distributed_trace_async
async def set_table_access_policy(
Expand Down
Loading