Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KeyVault] Handle Role Definition UUID Name Internally #14218

Merged
merged 5 commits into from
Oct 2, 2020

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Oct 2, 2020

Closes #13512.

Makes role_assignment_name a keyword-only argument for create_role_assignment in KeyVaultAccessControlClient, defaulting to a random UUID if not provided by the user.

@mccoyp mccoyp requested review from chlowell and iscai-msft October 2, 2020 20:28
@mccoyp mccoyp requested a review from schaabs as a code owner October 2, 2020 20:28
@ghost ghost added the KeyVault label Oct 2, 2020
@mccoyp mccoyp added the Client This issue points to a problem in the data-plane of the library. label Oct 2, 2020
@mccoyp mccoyp added this to the [2020] October milestone Oct 2, 2020
Copy link
Member

@chlowell chlowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please do the same for the async client.

@mccoyp mccoyp requested a review from chlowell October 2, 2020 22:20
chlowell
chlowell previously approved these changes Oct 2, 2020
@mccoyp mccoyp merged commit bfaaad3 into Azure:master Oct 2, 2020
@mccoyp mccoyp deleted the roleuuid branch October 2, 2020 23:44
iscai-msft added a commit that referenced this pull request Oct 7, 2020
…into fr-business-cards

* 'master' of https://github.com/Azure/azure-sdk-for-python: (71 commits)
  move the environment prep above the tooling that needs it (#14246)
  Increment version for appconfiguration releases (#14245)
  Azure Communication Service - Phone Number Administration (#14237)
  [text analytics] fix query param in cli call to get endpoint (#14243)
  Resolve Failing Documentation Build for azure-mgmt-core (#14239)
  Add code reviewers (#14229)
  [ServiceBus] make amqp_message properties read-only (#14095)
  [ServiceBus]remove topic parameter object settability (#14116)
  app config owner (#12986)
  [KeyVault] Handle Role Definition UUID Name Internally (#14218)
  Increment version for storage releases (#14224)
  Update Key Vault changelogs for October release (#14226)
  [ServiceBus] CI Test hotfixes (#14195)
  [text analytics] regen TA with GA autorest (#14215)
  [Storage][STG74]ChangeLog (#14192)
  fixes python 2.7 issue with unicode and strings again! (#14216)
  Feature/storage stg74 (#14175)
  Update communication pacakges to version b2 (#14209)
  [KeyVault] Add Status Methods to Query Backup and Restore Operations (#14158)
  Update buffered sender (#13851)
  ...
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request May 18, 2021
add AVS 2021-06-01 API (Azure#14215)

* add AVS 2021-06-01 API

* add cmdlets custom word

* rename ScriptCmdlet cmdletDescription to description (Azure#14218)

* Adding optional to the script parameter (Azure#14437)

Co-authored-by: David Becher <dabecher@microsoft.com>

Co-authored-by: david becher <dab4au@virginia.edu>
Co-authored-by: David Becher <dabecher@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[keyvault] handle role definition uuid name internally
2 participants